Android: Remove more unneeded bits.

Android: Remove more unneeded bits.

- file_system extensions API.
- various extensions API code.
- some print preview code.

BUG=305852
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281988

[not at google - send to devlin, 2014-07-08 15:18:14]

https://codereview.chromium.org/376813002/diff/1/chrome/browser/extensions/ch...
File chrome/browser/extensions/chrome_extension_host_delegate.cc (right):

https://codereview.chromium.org/376813002/diff/1/chrome/browser/extensions/ch...
chrome/browser/extensions/chrome_extension_host_delegate.cc:29:
ChromeExtensionWebContentsObserver::CreateForWebContents(web_contents);
there is going to be a lot of this. would it make sense to have some utility
like "CreateForWebContentsIfSupported" which does nothing on Android (and use
that basically everywhere).

https://codereview.chromium.org/376813002/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/api.gyp (left):

https://codereview.chromium.org/376813002/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/api.gyp:18: 'file_system.idl',
this part looks fine

[dgozman, 2014-07-08 19:17:48]

FYI, devtools_ui_bindings and more devtools files should not be compiled on
android. We can exclude them in chrome/chrome_debugger.gypi. I can post a patch.
Feel free to do it yourself if you want.

[Lei Zhang, 2014-07-08 19:31:57]

On 2014/07/08 19:17:48, dgozman wrote:
> FYI, devtools_ui_bindings and more devtools files should not be compiled on
> android. We can exclude them in chrome/chrome_debugger.gypi. I can post a
patch.
> Feel free to do it yourself if you want.

Thanks for letting me know. I'll take a shot at it and perhaps add it to this
CL.

[Lei Zhang, 2014-07-08 20:41:13]

dgozman: I excluded devtools_ui_bindings.cc and it builds. If there's more
devtools code that can be exclude, it would be great if you can do that in a
separate CL, and/or file a bug.

https://codereview.chromium.org/376813002/diff/1/chrome/browser/extensions/ch...
File chrome/browser/extensions/chrome_extension_host_delegate.cc (right):

https://codereview.chromium.org/376813002/diff/1/chrome/browser/extensions/ch...
chrome/browser/extensions/chrome_extension_host_delegate.cc:29:
ChromeExtensionWebContentsObserver::CreateForWebContents(web_contents);
On 2014/07/08 15:18:14, kalman wrote:
> there is going to be a lot of this. would it make sense to have some utility
> like "CreateForWebContentsIfSupported" which does nothing on Android (and use
> that basically everywhere).

There are many, but a good percentage of them are in code that's not being
built, and most of the rest have been ifdefed already. This is in fact the last
one that I need to ifdef out.

[not at google - send to devlin, 2014-07-08 20:50:13]

lgtm

[Lei Zhang, 2014-07-09 05:14:29]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-07-09 05:15:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/376813002/20001

[commit-bot: I haz the power, 2014-07-09 07:36:49]

Change committed as 281988