Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 376803005: JavaScript unit test framework for Chrome remote desktop - Part II (Closed)

Created:
6 years, 5 months ago by kelvinp
Modified:
6 years, 5 months ago
Reviewers:
Sergey Ulanov, M-A Ruel
CC:
chromium-reviews, chromoting-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

JavaScript unit test framework - Part II This change enables running the JavaScript unit test on try bots and build bots using the browser test infrastructure. To run a QUnit test suite as a browser test. 1. include third_party/qunit/src/browser_test_harness.js in your qunit test suite. 2. Derive your browser test from QUnitBrowserTestRunner, and call RunTest with the URL of the test suite. 3. modify chrome_tests.gypi to add the c++ source of your browser test and add your test suite as a run time dependency of the browser_tests executable Summary of changes: 1. QUnit_browser_test_runner.h serves as a base class for a QUnit browser test. It navigates the browser to the QUnit test suite, calls browserTestHarness.run() and listens for the test results. 2. browser_test_harness.js serves as a test took on the QUnit test suite. Using the window.domAutomationController, browser_test_harness.js detects whether it is running under the browser test infrastructure to auto-enable itself and report results back to the browser test. 3. Updates browser_tests.isolate so that the test can run in an isolated test environment. See http://www.chromium.org/developers/testing/isolated-testing. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281872

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -13 lines) Patch
M chrome/browser_tests.isolate View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
A chrome/test/remoting/qunit_browser_test_runner.h View 1 chunk +24 lines, -0 lines 0 comments Download
A chrome/test/remoting/qunit_browser_test_runner.cc View 1 chunk +53 lines, -0 lines 0 comments Download
A chrome/test/remoting/webapp_javascript_unittest.cc View 1 chunk +28 lines, -0 lines 0 comments Download
M remoting/remoting_test.gypi View 2 chunks +8 lines, -4 lines 0 comments Download
M remoting/webapp/html/template_unittest.html View 1 chunk +7 lines, -6 lines 0 comments Download
M remoting/webapp/unittests/test_eventSource.js View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/qunit/README.chromium View 1 chunk +3 lines, -1 line 0 comments Download
A third_party/qunit/src/browser_test_harness.js View 1 chunk +97 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kelvinp
PTAL
6 years, 5 months ago (2014-07-08 17:30:16 UTC) #1
M-A Ruel
browser_tests.isolate lgtm.
6 years, 5 months ago (2014-07-08 17:32:31 UTC) #2
Sergey Ulanov
lgtm
6 years, 5 months ago (2014-07-08 17:53:21 UTC) #3
kelvinp
The CQ bit was checked by kelvinp@chromium.org
6 years, 5 months ago (2014-07-08 17:54:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kelvinp@chromium.org/376803005/1
6 years, 5 months ago (2014-07-08 17:57:25 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 23:19:50 UTC) #6
Message was sent while issue was closed.
Change committed as 281872

Powered by Google App Engine
This is Rietveld 408576698