Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 376803004: Adding validation before using an SkImageInfo object read from an SkReadBuffer. (Closed)

Created:
6 years, 5 months ago by sugoi1
Modified:
6 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Adding validation before using an SkImageInfo object read from an SkReadBuffer. BUG=389574 Committed: https://skia.googlesource.com/skia/+/ca95c19d27b505a1ac8f57b53cb49c198bc29267

Patch Set 1 #

Patch Set 2 : Added missing check before computing minRowBytes() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/core/SkBitmap.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sugoi1
6 years, 5 months ago (2014-07-08 15:36:25 UTC) #1
Stephen White
LGTM
6 years, 5 months ago (2014-07-08 15:41:59 UTC) #2
sugoi1
The CQ bit was checked by sugoi@chromium.org
6 years, 5 months ago (2014-07-08 15:50:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/sugoi@chromium.org/376803004/20001
6 years, 5 months ago (2014-07-08 15:51:07 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 16:18:51 UTC) #5
Message was sent while issue was closed.
Change committed as ca95c19d27b505a1ac8f57b53cb49c198bc29267

Powered by Google App Engine
This is Rietveld 408576698