[DevTools] Color values should be case insensitive while suggestions should be case aware

Source/devtools/front_end/sdk/CSSMetadata.js

Index: Source/devtools/front_end/sdk/CSSMetadata.js
diff --git a/Source/devtools/front_end/sdk/CSSMetadata.js b/Source/devtools/front_end/sdk/CSSMetadata.js
index d43d57d73e9516306c4899f2dd77ad53d8702945..10e516a1947ab994a5835cad80d2768791dd47b7 100644
--- a/Source/devtools/front_end/sdk/CSSMetadata.js
+++ b/Source/devtools/front_end/sdk/CSSMetadata.js
@@ -76,7 +76,7 @@ WebInspector.CSSMetadata.cssPropertiesMetainfo = new WebInspector.CSSMetadata([]
  */
 WebInspector.CSSMetadata.isColorAwareProperty = function(propertyName)
 {
-    return WebInspector.CSSMetadata._colorAwareProperties[propertyName] === true;
+    return WebInspector.CSSMetadata._colorAwareProperties[propertyName.toLowerCase()] === true;

[vivekg, 2014/07/08 11:03:37]

This enables the swatch in non-case sensitive way.

[apavlov, 2014/07/08 11:16:37]

Generally, we should never compare to boolean literals. Could you replace the
comparison by "!!WebInspector.CSSMetadata...."?

 }
 
 /**
@@ -724,10 +724,10 @@ WebInspector.CSSMetadata._propertyDataMap = {
 WebInspector.CSSMetadata.keywordsForProperty = function(propertyName)
 {
     var acceptedKeywords = ["inherit", "initial"];
-    var descriptor = WebInspector.CSSMetadata.descriptor(propertyName);
+    var descriptor = WebInspector.CSSMetadata.descriptor(propertyName.toLowerCase());

[apavlov, 2014/07/08 11:16:37]

This conversion should be done inside WebInspector.CSSMetadata.descriptor, since
it relies on the propertyName being lower-cased.

     if (descriptor && descriptor.values)
         acceptedKeywords.push.apply(acceptedKeywords, descriptor.values);
-    if (propertyName in WebInspector.CSSMetadata._colorAwareProperties)
+    if (propertyName.toLowerCase() in WebInspector.CSSMetadata._colorAwareProperties)

[vivekg, 2014/07/08 11:03:37]

This change enables the suggestion keywords for the propertyName

[apavlov, 2014/07/08 11:16:37]

Hmm, in fact, this does exactly the same as
WebInspector.CSSMetadata.isColorAwareProperty(). Could you replace this check by
a call to isColorAwareProperty()?

         acceptedKeywords.push.apply(acceptedKeywords, WebInspector.CSSMetadata._colors);
     return new WebInspector.CSSMetadata(acceptedKeywords);
 }