Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1204)

Unified Diff: Source/devtools/front_end/ui/TextPrompt.js

Issue 376803002: [DevTools] Color values should be case insensitive while suggestions should be case aware (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/sdk/CSSMetadata.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/ui/TextPrompt.js
diff --git a/Source/devtools/front_end/ui/TextPrompt.js b/Source/devtools/front_end/ui/TextPrompt.js
index 909135022016ab3b25485686c0f8caa72dbb4c29..f0281ede9ac5c1270d8c38bd9893723486b58c68 100644
--- a/Source/devtools/front_end/ui/TextPrompt.js
+++ b/Source/devtools/front_end/ui/TextPrompt.js
@@ -472,12 +472,12 @@ WebInspector.TextPrompt.prototype = {
this._commonPrefix = this._buildCommonPrefix(completions, wordPrefixLength);
if (this.isCaretAtEndOfPrompt()) {
+ var completionText = completions[selectedIndex];
+ var prefixText = this._userEnteredRange.toString();
+ var suffixText = completionText.substring(wordPrefixLength);
this._userEnteredRange.deleteContents();
this._element.normalize();
var finalSelectionRange = document.createRange();
- var completionText = completions[selectedIndex];
- var prefixText = completionText.substring(0, wordPrefixLength);
- var suffixText = completionText.substring(wordPrefixLength);
var prefixTextNode = document.createTextNode(prefixText);
fullWordRange.insertNode(prefixTextNode);
« no previous file with comments | « Source/devtools/front_end/sdk/CSSMetadata.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698