[DevTools] Color values should be case insensitive while suggestions should be case aware

Source/devtools/front_end/sdk/CSSMetadata.js

 /*
  * Copyright (C) 2010 Nikita Vasilyev. All rights reserved.
  * Copyright (C) 2010 Joseph Pecoraro. All rights reserved.
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
@@ skipping 58 matching lines @@
  * @type {!WebInspector.CSSMetadata}
  */
 WebInspector.CSSMetadata.cssPropertiesMetainfo = new WebInspector.CSSMetadata([]);
 
 /**
  * @param {string} propertyName
  * @return {boolean}
  */
 WebInspector.CSSMetadata.isColorAwareProperty = function(propertyName)
 {
-    return WebInspector.CSSMetadata._colorAwareProperties[propertyName] === true;
+    return WebInspector.CSSMetadata._colorAwareProperties[propertyName.toLowerCase()] === true;

[vivekg, 2014/07/08 11:03:37]

This enables the swatch in non-case sensitive way.

[apavlov, 2014/07/08 11:16:37]

Generally, we should never compare to boolean literals. Could you replace the
comparison by "!!WebInspector.CSSMetadata...."?

 }
 
 /**
  * @return {!Object.<string, boolean>}
  */
 WebInspector.CSSMetadata.colors = function()
 {
     if (!WebInspector.CSSMetadata._colorsKeySet)
         WebInspector.CSSMetadata._colorsKeySet = WebInspector.CSSMetadata._colors.keySet();
     return WebInspector.CSSMetadata._colorsKeySet;
@@ skipping 627 matching lines @@
     "z-index": { m: "visuren" }
 }
 
 /**
  * @param {string} propertyName
  * @return {!WebInspector.CSSMetadata}
  */
 WebInspector.CSSMetadata.keywordsForProperty = function(propertyName)
 {
     var acceptedKeywords = ["inherit", "initial"];
-    var descriptor = WebInspector.CSSMetadata.descriptor(propertyName);
+    var descriptor = WebInspector.CSSMetadata.descriptor(propertyName.toLowerCase());

[apavlov, 2014/07/08 11:16:37]

This conversion should be done inside WebInspector.CSSMetadata.descriptor, since
it relies on the propertyName being lower-cased.

     if (descriptor && descriptor.values)
         acceptedKeywords.push.apply(acceptedKeywords, descriptor.values);
-    if (propertyName in WebInspector.CSSMetadata._colorAwareProperties)
+    if (propertyName.toLowerCase() in WebInspector.CSSMetadata._colorAwareProperties)

[vivekg, 2014/07/08 11:03:37]

This change enables the suggestion keywords for the propertyName

[apavlov, 2014/07/08 11:16:37]

Hmm, in fact, this does exactly the same as
WebInspector.CSSMetadata.isColorAwareProperty(). Could you replace this check by
a call to isColorAwareProperty()?

         acceptedKeywords.push.apply(acceptedKeywords, WebInspector.CSSMetadata._colors);
     return new WebInspector.CSSMetadata(acceptedKeywords);
 }
 
 /**
  * @param {string} propertyName
  * @return {?Object}
  */
 WebInspector.CSSMetadata.descriptor = function(propertyName)
 {
@@ skipping 279 matching lines @@
      * @param {string} longhand
      * @return {?Array.<string>}
      */
     shorthands: function(longhand)
     {
         return this._shorthands[longhand];
     }
 }
 
 WebInspector.CSSMetadata.initializeWithSupportedProperties([]);