LayoutTests/inspector/elements/styles/mixed-case-color-aware-properties.html - Issue 376803002: [DevTools] Color values should be case insensitive while suggestions should be case aware

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/inspector/elements/styles/mixed-case-color-aware-properties.html

Issue 376803002: [DevTools] Color values should be case insensitive while suggestions should be case aware (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Patch for landing! Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/inspector/elements/styles/case-sensitive-suggestions.html ('K') | « LayoutTests/inspector/elements/styles/case-sensitive-suggestions-expected.txt ('k') | LayoutTests/inspector/elements/styles/mixed-case-color-aware-properties-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script src="../../../http/tests/inspector/inspector-test.js"></script>

	4 <script src="../../../http/tests/inspector/elements-test.js"></script>

	5 <script>

	6

	7 function test()

	8 {

	9 var colorAwareProperties = ["bAckground-ColoR", "COloR", "Border-coLoR", "bo rder-right-color", "BOX-SHADOW"];

	10 for (var i = 0; i < colorAwareProperties.length; ++i) {

	11 if (WebInspector.CSSMetadata.isColorAwareProperty(colorAwareProperties[i ]))
	apavlov 2014/07/14 12:23:42 braces presence must be consistent across if-arms braces presence must be consistent across if-arms (then-else), see https://sites.google.com/a/chromium.org/dev/blink/coding-style [braces-must-match] apavlov 2014/07/14 12:23:42 We should rely on test expectations rather than so We should rely on test expectations rather than sophisticated test logic. You should always go the simplest route, like this one: for (var i = 0; i < colorAwareProperties.length; ++i) { var isColorAware = WebInspector.CSSMetadata.isColorAwareProperty(colorAwareProperties[i]); InspectorTest.addResult(colorAwareProperties[i] + (isColorAware ? " is" : " is NOT") + " color aware"); } vivekg 2014/07/14 17:57:51 Done. Show quoted text On 2014/07/14 12:23:42, apavlov wrote: > braces presence must be consistent across if-arms (then-else), see > https://sites.google.com/a/chromium.org/dev/blink/coding-style > [braces-must-match] Done. vivekg 2014/07/14 17:57:51 Done. Show quoted text On 2014/07/14 12:23:42, apavlov wrote: > We should rely on test expectations rather than sophisticated test logic. You > should always go the simplest route, like this one: > > for (var i = 0; i < colorAwareProperties.length; ++i) { > var isColorAware = > WebInspector.CSSMetadata.isColorAwareProperty(colorAwareProperties[i]); > InspectorTest.addResult(colorAwareProperties[i] + (isColorAware ? " is" : " > is NOT") + " color aware"); > } Done.
	12 result = "PASS";

	13 else {

	14 result = "FAIL: " + colorAwareProperties[i] + " is not listed as col or aware property.";

	15 break;

	16 }

	17 }

	18 InspectorTest.addResult("Result: " + result);

	19 InspectorTest.completeTest();

	20 }

	21 </script>

	22 </head>

	23

	24 <body onload="runTest()">

	25 <p>

	26 Tests that color related mixed-cased CSS properties are really color aware.
	apavlov 2014/07/14 12:23:42 color related -> color-related mixed-cased -> mix- color related -> color-related mixed-cased -> mix-cased really -> actually (for better readability) vivekg 2014/07/14 17:57:51 Done. Show quoted text On 2014/07/14 12:23:42, apavlov wrote: > color related -> color-related > mixed-cased -> mix-cased > really -> actually > (for better readability) Done.
	27 </p>

	28 </body>

	29 </html>

OLD	NEW