Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1920)

Issue 376783002: Use CSS3 flex to lay out Files.app components. (Closed)

Created:
6 years, 5 months ago by fukino
Modified:
6 years, 5 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Use CSS3 flex to lay out Files.app components. This CL includes: - Simple replacement by following rules. s/display: -webkit-box/display: flex/ s/-webkit-box-orient: vertical/flex-direction: column/ s/-webkit-box-orient: horizontal/flex-direction: row/ s/-webkit-box-flex: 1/flex: auto/ s/-webkit-box-flex: 0/flex: none/ s/-webkit-box-pack: start/justify-content: flex-start/ s/-webkit-box-pack: end/justify-content: flex-end/ s/-webkit-box-pack: center/justify-content: center/ s/-webkit-box-align: center/align-items: center/ s/-webkit-box-align: baseline/align-items: baseline/ s/-webkit-box-align: stretch/align-items: stretch/ - Flex items in "-webkit-box" don't shrink by default, but ones in "flex" shrink by default. So some flex items are specified "flex: none;" additionally. - "vertical-align: middle;" doesn't work for flex items, so specify "align-items: center;" for their parents. - Some position adjustment taking care of difference between "-webkit-box" and "flex". (commented inline) BUG=387568 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281985

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -138 lines) Patch
M ui/file_manager/file_manager/foreground/css/combobutton.css View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/file_manager/file_manager/foreground/css/common.css View 5 chunks +10 lines, -10 lines 0 comments Download
M ui/file_manager/file_manager/foreground/css/drive_welcome.css View 6 chunks +12 lines, -11 lines 0 comments Download
M ui/file_manager/file_manager/foreground/css/file_manager.css View 52 chunks +134 lines, -112 lines 2 comments Download
M ui/file_manager/file_manager/foreground/css/table.css View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
fukino
yoshiki san, could you take a look? https://codereview.chromium.org/376783002/diff/1/ui/file_manager/file_manager/foreground/css/file_manager.css File ui/file_manager/file_manager/foreground/css/file_manager.css (right): https://codereview.chromium.org/376783002/diff/1/ui/file_manager/file_manager/foreground/css/file_manager.css#newcode300 ui/file_manager/file_manager/foreground/css/file_manager.css:300: margin: -12px ...
6 years, 5 months ago (2014-07-08 06:23:48 UTC) #1
yoshiki
lgtm. Thanks for cleaning up!
6 years, 5 months ago (2014-07-09 04:37:58 UTC) #2
fukino
On 2014/07/09 04:37:58, yoshiki wrote: > lgtm. Thanks for cleaning up! Thank you!
6 years, 5 months ago (2014-07-09 04:53:23 UTC) #3
fukino
The CQ bit was checked by fukino@chromium.org
6 years, 5 months ago (2014-07-09 04:53:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fukino@chromium.org/376783002/1
6 years, 5 months ago (2014-07-09 04:56:49 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 07:28:55 UTC) #6
Message was sent while issue was closed.
Change committed as 281985

Powered by Google App Engine
This is Rietveld 408576698