Issue 376763002: Decrease keep-alive period for the video channel to 200ms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 376763002: Decrease keep-alive period for the video channel to 200ms. (Closed)

Created:
6 years, 5 months ago by Sergey Ulanov

Modified:
6 years, 5 months ago

Reviewers:
Wez

CC:
chromium-reviews, chromoting-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Decrease keep-alive period for the video channel to 200ms. Keep-alive above 250ms causes PseudoTCP to reset congestion window between messages, making connection much less responsive. BUG=391991 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281677

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	remoting/host/video_scheduler.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/376763002/1

6 years, 5 months ago (2014-07-08 02:15:33 UTC) #4

Sergey Ulanov

On 2014/07/08 02:13:35, Wez wrote: > Why is 250ms the magic number? https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjingle/source/talk/p2p/base/pseudotcp.cc&ct=xref_usages&gs=cpp:cricket::MIN_RTO@chromium/../../third_party/libjingle/source/talk/p2p/base/pseudotcp.cc%257Cdef&l=124&gsn=MIN_RTO const uint32 ...

6 years, 5 months ago (2014-07-08 02:24:48 UTC) #5

Message was sent while issue was closed.

Change committed as 281677

Expand Messages | Collapse Messages