Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Unified Diff: chrome/common/net/x509_certificate_model.h

Issue 376753002: Fix webui cert viewer showing wrong cert chain on NSS and no chain on OpenSSL. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/net/x509_certificate_model.h
diff --git a/chrome/common/net/x509_certificate_model.h b/chrome/common/net/x509_certificate_model.h
index e990828fb608aa8a6634227ebc5144b0f285616b..af828bca5694492587ec6cde15df7a045cd5ec71 100644
--- a/chrome/common/net/x509_certificate_model.h
+++ b/chrome/common/net/x509_certificate_model.h
@@ -86,9 +86,11 @@ std::string HashCertSHA1(net::X509Certificate::OSCertHandle cert_handle);
// decoded U-label form. Otherwise, the string will be returned as is.
std::string ProcessIDN(const std::string& input);
-void GetCertChainFromCert(net::X509Certificate::OSCertHandle cert_handle,
+// Return cert chain, begining with cert->os_cert_handle(), followed by certs
+// from cert->GetIntermediateCertificates(). Does not take references, so the
+// caller must hold a reference to |cert| while using |cert_handles|.
+void GetCertChainFromCert(net::X509Certificate* cert,
net::X509Certificate::OSCertHandles* cert_handles);
-void DestroyCertChain(net::X509Certificate::OSCertHandles* cert_handles);
std::string GetCMSString(const net::X509Certificate::OSCertHandles& cert_chain,
size_t start, size_t end);

Powered by Google App Engine
This is Rietveld 408576698