Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Unified Diff: chrome/common/net/x509_certificate_model_openssl.cc

Issue 376753002: Fix webui cert viewer showing wrong cert chain on NSS and no chain on OpenSSL. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: re-do comment change Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/net/x509_certificate_model_nss.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/net/x509_certificate_model_openssl.cc
diff --git a/chrome/common/net/x509_certificate_model_openssl.cc b/chrome/common/net/x509_certificate_model_openssl.cc
index d51c0360faea01418d521ea5bc4fccb70098c028..2f6e92f5f3ee8959dcdbb324274fdaeb65ab38e7 100644
--- a/chrome/common/net/x509_certificate_model_openssl.cc
+++ b/chrome/common/net/x509_certificate_model_openssl.cc
@@ -1136,19 +1136,6 @@ std::string HashCertSHA1(net::X509Certificate::OSCertHandle cert_handle) {
return ProcessRawBytes(sha1_data, sha1_size);
}
-void GetCertChainFromCert(net::X509Certificate::OSCertHandle cert_handle,
- net::X509Certificate::OSCertHandles* cert_handles) {
- // TODO(bulach): how to get the chain out of a certificate?
- cert_handles->push_back(net::X509Certificate::DupOSCertHandle(cert_handle));
-}
-
-void DestroyCertChain(net::X509Certificate::OSCertHandles* cert_handles) {
- for (net::X509Certificate::OSCertHandles::iterator i = cert_handles->begin();
- i != cert_handles->end(); ++i)
- X509_free(*i);
- cert_handles->clear();
-}
-
std::string GetCMSString(const net::X509Certificate::OSCertHandles& cert_chain,
size_t start, size_t end) {
STACK_OF(X509)* certs = sk_X509_new_null();
« no previous file with comments | « chrome/common/net/x509_certificate_model_nss.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698