Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: net/cert/x509_certificate_unittest.cc

Issue 376753002: Fix webui cert viewer showing wrong cert chain on NSS and no chain on OpenSSL. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix test Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cert/x509_certificate_unittest.cc
diff --git a/net/cert/x509_certificate_unittest.cc b/net/cert/x509_certificate_unittest.cc
index 454fe074af168153c2f15099f2b00a671e88ee14..8c0afb6ce400fe7719247c75d0af8dc48c606b51 100644
--- a/net/cert/x509_certificate_unittest.cc
+++ b/net/cert/x509_certificate_unittest.cc
@@ -682,6 +682,17 @@ TEST(X509CertificateTest, IntermediateCertificates) {
EXPECT_TRUE(X509Certificate::IsSameOSCert(cert2_intermediates[1],
thawte_cert->os_cert_handle()));
+ // Verify GetCertificateChain has the cert and all the intermediates:
+ X509Certificate::OSCertHandles cert2_chain;
+ cert2->GetCertificateChain(&cert2_chain);
+ ASSERT_EQ(3u, cert2_chain.size());
+ EXPECT_TRUE(X509Certificate::IsSameOSCert(cert2_chain[0],
+ cert2->os_cert_handle()));
+ EXPECT_TRUE(X509Certificate::IsSameOSCert(cert2_chain[1],
+ webkit_cert->os_cert_handle()));
+ EXPECT_TRUE(X509Certificate::IsSameOSCert(cert2_chain[2],
+ thawte_cert->os_cert_handle()));
+
// Cleanup
X509Certificate::FreeOSCertHandle(google_handle);
}

Powered by Google App Engine
This is Rietveld 408576698