chrome/browser/ui/webui/certificate_viewer_webui.h - Issue 376753002: Fix webui cert viewer showing wrong cert chain on NSS and no chain on OpenSSL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/certificate_viewer_webui.h

Issue 376753002: Fix webui cert viewer showing wrong cert chain on NSS and no chain on OpenSSL. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/certificate_dialogs.cc ('K') | « chrome/browser/ui/certificate_dialogs.cc ('k') | chrome/browser/ui/webui/certificate_viewer_webui.cc » ('j') | chrome/browser/ui/webui/certificate_viewer_webui.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/certificate_viewer_webui.h

diff --git a/chrome/browser/ui/webui/certificate_viewer_webui.h b/chrome/browser/ui/webui/certificate_viewer_webui.h

index 29e5ea6953b2f5395579ba99def20f0af75acb10..4873bae95bf1ad0702f9ee1069ad2864f5416723 100644

--- a/chrome/browser/ui/webui/certificate_viewer_webui.h

+++ b/chrome/browser/ui/webui/certificate_viewer_webui.h

@@ -133,7 +133,8 @@ class CertificateViewerDialogHandler : public content::WebUIMessageHandler {

// The dialog.

CertificateViewerModalDialog* dialog_;

- // The certificate chain.

+ // The certificate chain. Does not take references, so only valid as long as

+ // |cert_| is.

net::X509Certificate::OSCertHandles cert_chain_;

DISALLOW_COPY_AND_ASSIGN(CertificateViewerDialogHandler);