Fix webui cert viewer showing wrong cert chain on NSS and no chain on OpenSSL.

chrome/browser/ui/certificate_dialogs.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_CERTIFICATE_DIALOGS_H_
 #define CHROME_BROWSER_UI_CERTIFICATE_DIALOGS_H_
 
 #include "net/cert/x509_certificate.h"
 #include "ui/shell_dialogs/select_file_dialog.h"
 
 namespace content {
 class WebContents;
 }
 
 void ShowCertSelectFileDialog(ui::SelectFileDialog* select_file_dialog,
                               ui::SelectFileDialog::Type type,
                               const base::FilePath& suggested_path,
                               gfx::NativeWindow parent,
                               void* params);
 
+// Show a save dialog allowing to save |cert| alone or the cert + its chain.

[msw, 2014/07/11 17:25:40]

nit: consider: "Show a dialog to save |cert|, potentially with its chain."

[mattm, 2014/07/11 22:21:57]

removed

 void ShowCertExportDialog(content::WebContents* web_contents,
                           gfx::NativeWindow parent,
-                          net::X509Certificate::OSCertHandle cert);
+                          const scoped_refptr<net::X509Certificate>& cert);
+
+// Show a save dialog allowing to save the certificate pointed to by

[msw, 2014/07/11 17:25:40]

nit: consider: "Show a dialog to save the chain of certificates encompassed by
the iterators."

[mattm, 2014/07/11 22:21:57]

done(-ish)

+// |certs_begin| or the entire chain of |certs_begin|..|certs_end|.
+void ShowCertExportDialog(

[msw, 2014/07/11 17:25:40]

Overloading function names is discouraged, can you differentiate these? Does it
make more sense to only have this iterator impl and update the callers?

[mattm, 2014/07/11 22:21:57]

Done.

+    content::WebContents* web_contents,
+    gfx::NativeWindow parent,
+    net::X509Certificate::OSCertHandles::iterator certs_begin,
+    net::X509Certificate::OSCertHandles::iterator certs_end);
 
 #endif  // CHROME_BROWSER_UI_CERTIFICATE_DIALOGS_H_