Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(939)

Unified Diff: chrome/browser/ui/webui/chromeos/login/update_screen_handler.cc

Issue 376733005: improve translateability of some OOBE strings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/chromeos/login/update_screen_handler.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/update_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/update_screen_handler.cc
index 38b756fd25d6ed23d2d3c74b7fecb021690df34d..0b8824eff355f500049f880e4abc633f5dde40bf 100644
--- a/chrome/browser/ui/webui/chromeos/login/update_screen_handler.cc
+++ b/chrome/browser/ui/webui/chromeos/login/update_screen_handler.cc
@@ -32,11 +32,8 @@ UpdateScreenHandler::~UpdateScreenHandler() {
void UpdateScreenHandler::DeclareLocalizedValues(
LocalizedValuesBuilder* builder) {
- builder->AddF("checkingForUpdatesMsg",
- IDS_CHECKING_FOR_UPDATE_MSG, IDS_SHORT_PRODUCT_NAME);
- builder->AddF("installingUpdateDesc",
- IDS_UPDATE_MSG, IDS_SHORT_PRODUCT_NAME);
-
+ builder->Add("checkingForUpdatesMsg", IDS_CHECKING_FOR_UPDATE_MSG);
+ builder->Add("installingUpdateDesc", IDS_UPDATE_MSG);
builder->Add("updateScreenTitle", IDS_UPDATE_SCREEN_TITLE);
builder->Add("updateScreenAccessibleTitle",
IDS_UPDATE_SCREEN_ACCESSIBLE_TITLE);
@@ -107,30 +104,26 @@ void UpdateScreenHandler::ShowProgressMessage(bool visible) {
}
void UpdateScreenHandler::SetProgressMessage(ProgressMessage message) {
- scoped_ptr<base::StringValue> progress_message;
+ int ids = 0;
switch (message) {
case PROGRESS_MESSAGE_UPDATE_AVAILABLE:
- progress_message.reset(base::Value::CreateStringValue(
- l10n_util::GetStringUTF16(IDS_UPDATE_AVAILABLE)));
+ ids = IDS_UPDATE_AVAILABLE;
break;
case PROGRESS_MESSAGE_INSTALLING_UPDATE:
- progress_message.reset(base::Value::CreateStringValue(
- l10n_util::GetStringFUTF16(IDS_INSTALLING_UPDATE,
- l10n_util::GetStringUTF16(IDS_SHORT_PRODUCT_NAME))));
+ ids = IDS_INSTALLING_UPDATE;
break;
case PROGRESS_MESSAGE_VERIFYING:
- progress_message.reset(base::Value::CreateStringValue(
- l10n_util::GetStringUTF16(IDS_UPDATE_VERIFYING)));
+ ids = IDS_UPDATE_VERIFYING;
break;
case PROGRESS_MESSAGE_FINALIZING:
- progress_message.reset(base::Value::CreateStringValue(
- l10n_util::GetStringUTF16(IDS_UPDATE_FINALIZING)));
+ ids = IDS_UPDATE_FINALIZING;
break;
default:
NOTREACHED();
- };
- if (progress_message.get())
- CallJS("setProgressMessage", *progress_message);
+ return;
+ }
+
+ CallJS("setProgressMessage", l10n_util::GetStringUTF16(ids));
}
void UpdateScreenHandler::ShowCurtain(bool visible) {
« no previous file with comments | « chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698