MacViews: Tweak ComboboxTest.GetTextForRowTest to get it to pass.

ui/views/controls/combobox/combobox_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/combobox/combobox.h"
 
 #include <set>
 
 #include "base/basictypes.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 74 matching lines @@
 
   DISALLOW_COPY_AND_ASSIGN(TestCombobox);
 };
 
 // A concrete class is needed to test the combobox.
 class TestComboboxModel : public ui::ComboboxModel {
  public:
   TestComboboxModel() {}
   virtual ~TestComboboxModel() {}
 
+  static const int kItemCount = 10;
+
   // ui::ComboboxModel:
   virtual int GetItemCount() const OVERRIDE {
-    return 10;
+    return kItemCount;
   }
   virtual base::string16 GetItemAt(int index) OVERRIDE {
     if (IsItemSeparatorAt(index)) {
       NOTREACHED();
       return ASCIIToUTF16("SEPARATOR");
     }
     return ASCIIToUTF16(index % 2 == 0 ? "PEANUT BUTTER" : "JELLY");
   }
   virtual bool IsItemSeparatorAt(int index) OVERRIDE {
     return separators_.find(index) != separators_.end();
   }
 
+  virtual int GetDefaultIndex() const OVERRIDE {
+    // Return the first index that is not a separator.
+    for (int index = 0; index < kItemCount; ++index) {
+      if (separators_.find(index) == separators_.end())
+        return index;
+    }
+    NOTREACHED();
+    return 0;
+  }
+
   void SetSeparators(const std::set<int>& separators) {
     separators_ = separators;
   }
 
  private:
   std::set<int> separators_;
 
   DISALLOW_COPY_AND_ASSIGN(TestComboboxModel);
 };
 
@@ skipping 73 matching lines @@
 class ComboboxTest : public ViewsTestBase {
  public:
   ComboboxTest() : widget_(NULL), combobox_(NULL) {}
 
   virtual void TearDown() OVERRIDE {
     if (widget_)
       widget_->Close();
     ViewsTestBase::TearDown();
   }
 
-  void InitCombobox() {
+  void InitCombobox(const std::set<int>* separators = NULL) {

[sadrul, 2014/07/10 15:24:35]

I believe default parameters are not allowed. Just send NULL from the rest of
the calls.

[Andre, 2014/07/10 17:44:27]

Done.

     model_.reset(new TestComboboxModel());
 
+    if (separators)
+      model_->SetSeparators(*separators);
+
     ASSERT_FALSE(combobox_);
     combobox_ = new TestCombobox(model_.get());
     combobox_->set_id(1);
 
     widget_ = new Widget;
     Widget::InitParams params = CreateParams(Widget::InitParams::TYPE_POPUP);
     params.bounds = gfx::Rect(200, 200, 200, 200);
     widget_->Init(params);
     View* container = new View();
     widget_->SetContentsView(container);
@@ skipping 81 matching lines @@
   widget_->Init(params);
   View* container = new View();
   widget_->SetContentsView(container);
   container->AddChildView(combobox_);
   EXPECT_FALSE(combobox_->enabled());
 }
 
 // Verifies that we don't select a separator line in combobox when navigating
 // through keyboard.
 TEST_F(ComboboxTest, SkipSeparatorSimple) {
-  InitCombobox();
   std::set<int> separators;
   separators.insert(2);
-  model_->SetSeparators(separators);
+  InitCombobox(&separators);
   EXPECT_EQ(0, combobox_->selected_index());
   SendKeyEvent(ui::VKEY_DOWN);
   EXPECT_EQ(1, combobox_->selected_index());
   SendKeyEvent(ui::VKEY_DOWN);
   EXPECT_EQ(3, combobox_->selected_index());
   SendKeyEvent(ui::VKEY_UP);
   EXPECT_EQ(1, combobox_->selected_index());
   SendKeyEvent(ui::VKEY_HOME);
   EXPECT_EQ(0, combobox_->selected_index());
   SendKeyEvent(ui::VKEY_PRIOR);
   EXPECT_EQ(0, combobox_->selected_index());
   SendKeyEvent(ui::VKEY_END);
   EXPECT_EQ(9, combobox_->selected_index());
 }
 
 // Verifies that we never select the separator that is in the beginning of the
 // combobox list when navigating through keyboard.
 TEST_F(ComboboxTest, SkipSeparatorBeginning) {
-  InitCombobox();
   std::set<int> separators;
   separators.insert(0);
-  model_->SetSeparators(separators);
-  EXPECT_EQ(0, combobox_->selected_index());
-  SendKeyEvent(ui::VKEY_DOWN);
+  InitCombobox(&separators);
   EXPECT_EQ(1, combobox_->selected_index());
   SendKeyEvent(ui::VKEY_DOWN);
   EXPECT_EQ(2, combobox_->selected_index());
+  SendKeyEvent(ui::VKEY_DOWN);
+  EXPECT_EQ(3, combobox_->selected_index());
   SendKeyEvent(ui::VKEY_UP);
-  EXPECT_EQ(1, combobox_->selected_index());
+  EXPECT_EQ(2, combobox_->selected_index());
   SendKeyEvent(ui::VKEY_HOME);
   EXPECT_EQ(1, combobox_->selected_index());
   SendKeyEvent(ui::VKEY_PRIOR);
   EXPECT_EQ(1, combobox_->selected_index());
   SendKeyEvent(ui::VKEY_END);
   EXPECT_EQ(9, combobox_->selected_index());
 }
 
 // Verifies that we never select the separator that is in the end of the
 // combobox list when navigating through keyboard.
 TEST_F(ComboboxTest, SkipSeparatorEnd) {
-  InitCombobox();
   std::set<int> separators;
-  separators.insert(model_->GetItemCount() - 1);
-  model_->SetSeparators(separators);
+  separators.insert(TestComboboxModel::kItemCount - 1);
+  InitCombobox(&separators);
   combobox_->SetSelectedIndex(8);
   SendKeyEvent(ui::VKEY_DOWN);
   EXPECT_EQ(8, combobox_->selected_index());
   SendKeyEvent(ui::VKEY_UP);
   EXPECT_EQ(7, combobox_->selected_index());
   SendKeyEvent(ui::VKEY_END);
   EXPECT_EQ(8, combobox_->selected_index());
 }
 
 // Verifies that we never select any of the adjacent separators (multiple
 // consecutive) that appear in the beginning of the combobox list when
 // navigating through keyboard.
 TEST_F(ComboboxTest, SkipMultipleSeparatorsAtBeginning) {
-  InitCombobox();
   std::set<int> separators;
   separators.insert(0);
   separators.insert(1);
   separators.insert(2);
-  model_->SetSeparators(separators);
-  EXPECT_EQ(0, combobox_->selected_index());
+  InitCombobox(&separators);
+  EXPECT_EQ(3, combobox_->selected_index());
   SendKeyEvent(ui::VKEY_DOWN);
-  EXPECT_EQ(3, combobox_->selected_index());
+  EXPECT_EQ(4, combobox_->selected_index());
   SendKeyEvent(ui::VKEY_UP);
   EXPECT_EQ(3, combobox_->selected_index());
   SendKeyEvent(ui::VKEY_NEXT);
   EXPECT_EQ(9, combobox_->selected_index());
   SendKeyEvent(ui::VKEY_HOME);
   EXPECT_EQ(3, combobox_->selected_index());
   SendKeyEvent(ui::VKEY_END);
   EXPECT_EQ(9, combobox_->selected_index());
   SendKeyEvent(ui::VKEY_PRIOR);
   EXPECT_EQ(3, combobox_->selected_index());
 }
 
 // Verifies that we never select any of the adjacent separators (multiple
 // consecutive) that appear in the middle of the combobox list when navigating
 // through keyboard.
 TEST_F(ComboboxTest, SkipMultipleAdjacentSeparatorsAtMiddle) {
-  InitCombobox();
   std::set<int> separators;
   separators.insert(4);
   separators.insert(5);
   separators.insert(6);
-  model_->SetSeparators(separators);
+  InitCombobox(&separators);
   combobox_->SetSelectedIndex(3);
   SendKeyEvent(ui::VKEY_DOWN);
   EXPECT_EQ(7, combobox_->selected_index());
   SendKeyEvent(ui::VKEY_UP);
   EXPECT_EQ(3, combobox_->selected_index());
 }
 
 // Verifies that we never select any of the adjacent separators (multiple
 // consecutive) that appear in the end of the combobox list when navigating
 // through keyboard.
 TEST_F(ComboboxTest, SkipMultipleSeparatorsAtEnd) {
-  InitCombobox();
   std::set<int> separators;
   separators.insert(7);
   separators.insert(8);
   separators.insert(9);
-  model_->SetSeparators(separators);
+  InitCombobox(&separators);
   combobox_->SetSelectedIndex(6);
   SendKeyEvent(ui::VKEY_DOWN);
   EXPECT_EQ(6, combobox_->selected_index());
   SendKeyEvent(ui::VKEY_UP);
   EXPECT_EQ(5, combobox_->selected_index());
   SendKeyEvent(ui::VKEY_HOME);
   EXPECT_EQ(0, combobox_->selected_index());
   SendKeyEvent(ui::VKEY_NEXT);
   EXPECT_EQ(6, combobox_->selected_index());
   SendKeyEvent(ui::VKEY_PRIOR);
   EXPECT_EQ(0, combobox_->selected_index());
   SendKeyEvent(ui::VKEY_END);
   EXPECT_EQ(6, combobox_->selected_index());
 }
 
 TEST_F(ComboboxTest, GetTextForRowTest) {
-  InitCombobox();
   std::set<int> separators;
   separators.insert(0);
   separators.insert(1);
   separators.insert(9);
-  model_->SetSeparators(separators);
+  InitCombobox(&separators);
   for (int i = 0; i < combobox_->GetRowCount(); ++i) {
     if (separators.count(i) != 0) {
       EXPECT_TRUE(combobox_->GetTextForRow(i).empty()) << i;
     } else {
       EXPECT_EQ(ASCIIToUTF16(i % 2 == 0 ? "PEANUT BUTTER" : "JELLY"),
                 combobox_->GetTextForRow(i)) << i;
     }
   }
 }
 
@@ skipping 236 matching lines @@
   combobox_->OnBlur();
 
   // Type the first character of "PEANUT BUTTER", which should change the
   // selected index and perform an action.
   combobox_->GetTextInputClient()->InsertChar('P', ui::EF_NONE);
   EXPECT_EQ(2, listener.actions_performed());
   EXPECT_EQ(2, listener.perform_action_index());
 }
 
 }  // namespace views