MacViews: Tweak ComboboxTest.GetTextForRowTest to get it to pass.

ui/views/controls/combobox/combobox_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/combobox/combobox.h"
 
 #include <set>
 
 #include "base/basictypes.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 413 matching lines @@
   EXPECT_EQ(6, combobox_->selected_index());
   SendKeyEvent(ui::VKEY_PRIOR);
   EXPECT_EQ(0, combobox_->selected_index());
   SendKeyEvent(ui::VKEY_END);
   EXPECT_EQ(6, combobox_->selected_index());
 }
 
 TEST_F(ComboboxTest, GetTextForRowTest) {
   InitCombobox();
   std::set<int> separators;
-  separators.insert(0);

[msw, 2014/07/07 23:37:22]

I think it was our intention here to ensure that a 0-index separator didn't
Combobox problems. Rather than revising the test, perhaps we should revise the
Mac-specific code that causes this to fail on that platform? Or perhaps we want
to revise the cross-platform handling of separators in GetItemAt (or the
selected index initialization).

   separators.insert(1);
+  separators.insert(2);
   separators.insert(9);
   model_->SetSeparators(separators);
   for (int i = 0; i < combobox_->GetRowCount(); ++i) {
     if (separators.count(i) != 0) {
       EXPECT_TRUE(combobox_->GetTextForRow(i).empty()) << i;
     } else {
       EXPECT_EQ(ASCIIToUTF16(i % 2 == 0 ? "PEANUT BUTTER" : "JELLY"),
                 combobox_->GetTextForRow(i)) << i;
     }
   }
@@ skipping 238 matching lines @@
   combobox_->OnBlur();
 
   // Type the first character of "PEANUT BUTTER", which should change the
   // selected index and perform an action.
   combobox_->GetTextInputClient()->InsertChar('P', ui::EF_NONE);
   EXPECT_EQ(2, listener.actions_performed());
   EXPECT_EQ(2, listener.perform_action_index());
 }
 
 }  // namespace views