cc/output/software_renderer.cc - Issue 376683004: Pass resourceless software mode in BeginFrameArgs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/output/software_renderer.cc

Issue 376683004: Pass resourceless software mode in BeginFrameArgs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: comment, clang-format Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/output/software_renderer.cc

diff --git a/cc/output/software_renderer.cc b/cc/output/software_renderer.cc

index 0f6babc30ec265011291edf6732bbefedab4fc2a..0a04f098771111c7dcf8ee75142cb07cd2200b1f 100644

--- a/cc/output/software_renderer.cc

+++ b/cc/output/software_renderer.cc

@@ -472,7 +472,9 @@ void SoftwareRenderer::DrawTextureQuad(const DrawingFrame* frame,

void SoftwareRenderer::DrawTileQuad(const DrawingFrame* frame,

const TileDrawQuad* quad) {

- DCHECK(!output_surface_->ForcedDrawToSoftwareDevice());

+ // |resource_provider_| can be NULL in resourceless software draws, which

+ // should never produce tile quads in the first place.

+ DCHECK(resource_provider_);

DCHECK(IsSoftwareResource(quad->resource_id));

ResourceProvider::ScopedReadLockSoftware lock(resource_provider_,