Calculate severity score for date_invalid error

chrome/browser/ssl/ssl_severity_date_invalid.h

Index: chrome/browser/ssl/ssl_severity_date_invalid.h
diff --git a/chrome/browser/ssl/ssl_severity_date_invalid.h b/chrome/browser/ssl/ssl_severity_date_invalid.h
new file mode 100644
index 0000000000000000000000000000000000000000..f356978a955afcc0bf1dadc5da5e1c6e3ddd3308
--- /dev/null
+++ b/chrome/browser/ssl/ssl_severity_date_invalid.h
@@ -0,0 +1,39 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_SSL_SSL_SEVERITY_DATE_INVALID_H_
+#define CHROME_BROWSER_SSL_SSL_SEVERITY_DATE_INVALID_H_
+#endif
+
+#include "base/time/time.h"
+#include "net/cert/x509_certificate.h"
+
+// This class describes the functions which will be usefule in calcualting the
+// severity score when the SSL Error is Date Invalid.

[felt, 2014/07/07 22:01:34]

^ make sure to read your comments, there are two big typos

[radhikabhar, 2014/07/09 17:17:12]

Done.

+class SSLSeverityDateInvalid {

[felt, 2014/07/07 22:01:34]

I don't think you need to make a new class for each type of error. You're going
to end up wanting to reuse things, like whether the user has visited the page
before, across different error types.

Instead, it probably makes sense to make a single class that has a whole bunch
of generic helper functions. For example:

class SSLErrorClassification {
 private:
  bool IsUserClockWrong();
}

Then you can later add methods that make use of the helper functions, like:

float ScoreDateInvalid() {
  float score = 0;
  if (IsUserClockWrong()) score = score + .4; 
}

That way you can also have a method like:

void RecordUMAStatistics() {
  if (IsUserClockWrong()) {
    // record UMA stat
  }
  if (IsItCloudyToday()) {
    // record UMA stat
  }
}

You can also move the SSLInterstitialCause and RecordSSLInterstitialCause here,
from the ssl_blocking_page.cc. Then have SSLBlockingPage::GetHTMLContentsV2
invoke your method to see whether the user's time wrong.

[radhikabhar, 2014/07/09 17:17:12]

Done.

+ public :
+  // A function which calcualtes the weight of the client characteristics in
+  // contributing towards the SSL error.
+  float ClientCharacteristics();
+
+  // A function which calculates the weight of the server characteristics in
+  // contributing towards the SSL error.
+  float ServerCharacteristics();
+
+  SSLSeverityDateInvalid(base::Time current_time,
+                         net::X509Certificate* cert);
+  ~SSLSeverityDateInvalid();
+
+ private:
+
+  float IsUserClockWrong();
+  float TimePassedSinceExpiry();
+
+  // This stores the current time.
+  base::Time current_time_;
+
+  // This stores the certificate.
+  net::X509Certificate* cert_ ;
+  FRIEND_TEST_ALL_PREFIXES(SSLSeverityDateInvalidTest, IsUserClockWrongTest);
+};