Calculate severity score for date_invalid error

chrome/browser/ssl/ssl_error_classification.h

Index: chrome/browser/ssl/ssl_error_classification.h
diff --git a/chrome/browser/ssl/ssl_error_classification.h b/chrome/browser/ssl/ssl_error_classification.h
new file mode 100644
index 0000000000000000000000000000000000000000..4bb5fd1e48af8d834b8edfd967dd1fbe842928cb
--- /dev/null
+++ b/chrome/browser/ssl/ssl_error_classification.h
@@ -0,0 +1,40 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_SSL_SSL_ERROR_CLASSIFICATION_H_
+#define CHROME_BROWSER_SSL_SSL_ERROR_CLASSIFICATION_H_
+#endif
+
+#include "base/time/time.h"
+#include "net/cert/x509_certificate.h"
+
+// This class describes the functions which will be useful in calculating the
+// severity score when the SSL Error is Date Invalid.

[felt, 2014/07/09 19:00:45]

this class doesn't have to be specific to Date Invalid. can you update the
comment?

[radhikabhar, 2014/07/10 17:14:47]

Done.

+class SSLErrorClassification {
+ public :

[felt, 2014/07/09 19:00:45]

the spacing should be

 public:  // one space
  float ...  // two spaces

+  // A function which calcualtes the weight of the client characteristics in
+  // contributing towards the SSL error.
+  float ClientCharacteristics();
+
+  // A function which calculates the weight of the server characteristics in
+  // contributing towards the SSL error.
+  float ServerCharacteristics();
+
+  static bool IsUserClockInThePast(bool overridable, base::Time time_now);
+  static bool IsUserClockInTheFuture(bool overridable, base::Time time_now);
+
+  SSLErrorClassification(base::Time current_time,
+                         net::X509Certificate* cert);
+  ~SSLErrorClassification();

[felt, 2014/07/09 19:00:45]

I don't think these methods are in the right order. Can you look at the C++
style guide google-styleguide.googlecode.com/svn/trunk/cppguide.xml and make
sure they are ordered correctly?

[radhikabhar, 2014/07/10 17:14:47]

Done.

+
+ private:
+

[felt, 2014/07/09 19:00:45]

nit: no enter here

[radhikabhar, 2014/07/10 17:14:47]

Done.

+  float TimePassedSinceExpiry();
+
+  // This stores the current time.
+  base::Time current_time_;
+
+  // This stores the certificate.
+  net::X509Certificate* cert_ ;
+};