Issue 376623002: rebaseline_server: allow JSON to control column filtering

Issue 376623002: rebaseline_server: allow JSON to control column filtering (Closed)

Created:
6 years, 5 months ago by epoger

Modified:
6 years, 5 months ago

Reviewers:
rmistry

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

rebaseline_server: allow JSON to control column filtering Makes the rebaseline_server client more generic, allowing the server to tweak display properties by writing directives into the JSON file. Adds two new fields to the rebaseline_server JSON file (and thus increments VALUE__HEADER__SCHEMA_VERSION): 1. KEY__ROOT__EXTRACOLUMNORDER: order in which the client should display columns 2. KEY__EXTRACOLUMNHEADERS__USE_FREEFORM_FILTER: whether a column should be filtered using a freeform text field or checkboxes BUG=skia:2230 NOTRY=True Committed: https://skia.googlesource.com/skia/+/b4edbffd7c09ca172f95fc30381671962e22dee0

Patch Set 1 : make UI code display columns in a loop, rather than hard-coded for each column type #

Patch Set 2 : rename "category" and "categoryName" as "columnName" for consistency #

Patch Set 3 : allow server to recommend which columns we filter with checkboxes vs freeform text matching #

Patch Set 4 : allow server to recommend display order of columns #

Patch Set 5 : update expectations of existing unittests #

Patch Set 6 : add a new unittest, misc cleanup #

Patch Set 7 : rebase #

Total comments: 4

Patch Set 8 : Ravi suggestions #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+306 lines, -201 lines)			Patch
M	gm/rebaseline_server/column.py	View	1 2 3 4 5	4 chunks	+9 lines, -6 lines	0 comments	Download
M	gm/rebaseline_server/compare_to_expectations.py	View	1 2 3 4 5 6 7	5 chunks	+32 lines, -7 lines	0 comments	Download
M	gm/rebaseline_server/imagepairset.py	View	1 2 3 4 5	2 chunks	+22 lines, -1 line	0 comments	Download
M	gm/rebaseline_server/imagepairset_test.py	View	1 2 3 4 5	4 chunks	+24 lines, -2 lines	0 comments	Download
M	gm/rebaseline_server/results.py	View	1 2	4 chunks	+9 lines, -5 lines	0 comments	Download
M	gm/rebaseline_server/static/constants.js	View	1 2 3	3 chunks	+3 lines, -1 line	0 comments	Download
M	gm/rebaseline_server/static/loader.js	View	1 2 3 4 5	8 chunks	+112 lines, -70 lines	0 comments	Download
M	gm/rebaseline_server/static/view.html	View	1 2 3	3 chunks	+62 lines, -106 lines	0 comments	Download
M	gm/rebaseline_server/testdata/outputs/expected/compare_configs_test.CompareConfigsTest.test_gm/gm.json	View	1 2 3 4 5	5 chunks	+11 lines, -1 line	0 comments	Download
M	gm/rebaseline_server/testdata/outputs/expected/compare_rendered_pictures_test.CompareRenderedPicturesTest.test_endToEnd/compare_rendered_pictures.json	View	1 2 3 4 5	5 chunks	+11 lines, -1 line	0 comments	Download
M	gm/rebaseline_server/testdata/outputs/expected/compare_to_expectations_test.CompareToExpectationsTest.test_gm/gm.json	View	1 2 3 4	5 chunks	+11 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

epoger

Ready for review at patchset 7. User-observable behavior should not be changed by this CL. ...

6 years, 5 months ago (2014-07-08 18:31:34 UTC) #1

rmistry

LGTM https://codereview.chromium.org/376623002/diff/140001/gm/rebaseline_server/compare_to_expectations.py File gm/rebaseline_server/compare_to_expectations.py (right): https://codereview.chromium.org/376623002/diff/140001/gm/rebaseline_server/compare_to_expectations.py#newcode38 gm/rebaseline_server/compare_to_expectations.py:38: FREEFORM_COLUMN_IDS = [results.KEY__EXTRACOLUMNS__BUILDER, Nit: Create this list like ...

6 years, 5 months ago (2014-07-09 12:00:07 UTC) #2

epoger

Thanks. Committing now. https://codereview.chromium.org/376623002/diff/140001/gm/rebaseline_server/compare_to_expectations.py File gm/rebaseline_server/compare_to_expectations.py (right): https://codereview.chromium.org/376623002/diff/140001/gm/rebaseline_server/compare_to_expectations.py#newcode38 gm/rebaseline_server/compare_to_expectations.py:38: FREEFORM_COLUMN_IDS = [results.KEY__EXTRACOLUMNS__BUILDER, On 2014/07/09 12:00:07, ...

6 years, 5 months ago (2014-07-09 13:17:49 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/376623002/160001

6 years, 5 months ago (2014-07-09 13:19:10 UTC) #5

commit-bot: I haz the power

6 years, 5 months ago (2014-07-09 13:19:27 UTC) #6

Message was sent while issue was closed.

Change committed as b4edbffd7c09ca172f95fc30381671962e22dee0

Expand Messages | Collapse Messages