Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: test/ios/extension/ExtensionContainer/Info.plist

Issue 376603002: This CL adds support for extension in GYP. (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master
Patch Set: corrections Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/ios/extension/ExtensionContainer/Info.plist
diff --git a/test/mac/framework/TestFramework/Info.plist b/test/ios/extension/ExtensionContainer/Info.plist
similarity index 64%
copy from test/mac/framework/TestFramework/Info.plist
copy to test/ios/extension/ExtensionContainer/Info.plist
index a791b3ee48d1e6f1dbe0041aebfba642e5acbbd9..893d87e45b2db3d2fba9497caf876024075b7624 100644
--- a/test/mac/framework/TestFramework/Info.plist
+++ b/test/ios/extension/ExtensionContainer/Info.plist
@@ -3,26 +3,30 @@
<plist version="1.0">
<dict>
<key>CFBundleDevelopmentRegion</key>
- <string>English</string>
+ <string>en</string>
<key>CFBundleExecutable</key>
- <string>${EXECUTABLE_NAME}</string>
- <key>CFBundleIconFile</key>
- <string></string>
+ <string>ExtensionContainer</string>
<key>CFBundleIdentifier</key>
- <string>com.yourcompany.${PRODUCT_NAME:identifier}</string>
+ <string>com.google.chrome.ios.${PRODUCT_NAME:rfc1034identifier}</string>
justincohen 2014/07/07 16:21:42 same here.
olivierrobin 2014/07/08 09:48:18 Done.
<key>CFBundleInfoDictionaryVersion</key>
<string>6.0</string>
<key>CFBundleName</key>
<string>${PRODUCT_NAME}</string>
<key>CFBundlePackageType</key>
- <string>FMWK</string>
+ <string>APPL</string>
<key>CFBundleShortVersionString</key>
<string>1.0</string>
<key>CFBundleSignature</key>
<string>????</string>
<key>CFBundleVersion</key>
<string>1</string>
- <key>NSPrincipalClass</key>
- <string></string>
+ <key>LSRequiresIPhoneOS</key>
+ <true/>
+ <key>UIMainStoryboardFile</key>
+ <string>Main</string>
+ <key>UIRequiredDeviceCapabilities</key>
+ <array>
+ <string>armv7</string>
+ </array>
</dict>
</plist>

Powered by Google App Engine
This is Rietveld 408576698