Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 376573003: Pull necessary dependencies to be able to process mojo.gyp on iOS (Closed)

Created:
6 years, 5 months ago by blundell
Modified:
6 years, 3 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, qsr+mojo_chromium.org, rohitrao (ping after 24h), stuartmorgan, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Pull necessary dependencies to be able to process mojo.gyp on iOS This CL adds support for building the Mojo core system and C++ bindings-related targets on iOS. It also adds necessary dependencies such that mojo.gyp can be processed on iOS. This CL also rolls DEPS on libjpeg_turbo to catch a change to libjpeg.gyp that is needed in order for gyp to avoid choking when processing the file on iOS.

Patch Set 1 #

Patch Set 2 : Initialize Mojo on iOS #

Patch Set 3 : Rebase and add DEPS roll of libjpeg_turbo #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -53 lines) Patch
M DEPS View 1 2 3 1 chunk +32 lines, -38 lines 0 comments Download
M build/all.gyp View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download
M content/app/content_main_runner.cc View 1 2 3 3 chunks +1 line, -3 lines 0 comments Download
M content/content_app.gypi View 1 2 3 2 chunks +4 lines, -9 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M mojo/mojo_base.gyp View 1 2 3 3 chunks +22 lines, -0 lines 0 comments Download
M mojo/mojo_public_tests.gypi View 1 2 3 2 chunks +5 lines, -1 line 0 comments Download
M third_party/libxslt/libxslt.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
blundell
Hi James, How does this CL look? Note that the iOS bots are red because ...
6 years, 5 months ago (2014-07-10 09:52:04 UTC) #1
jamesr
https://codereview.chromium.org/376573003/diff/20001/mojo/mojo.gyp File mojo/mojo.gyp (right): https://codereview.chromium.org/376573003/diff/20001/mojo/mojo.gyp#newcode28 mojo/mojo.gyp:28: 'target_name': 'mojo', On 2014/07/10 09:52:04, blundell wrote: > I'd ...
6 years, 5 months ago (2014-07-10 22:28:22 UTC) #2
blundell
https://codereview.chromium.org/376573003/diff/20001/mojo/mojo.gyp File mojo/mojo.gyp (right): https://codereview.chromium.org/376573003/diff/20001/mojo/mojo.gyp#newcode28 mojo/mojo.gyp:28: 'target_name': 'mojo', What we've done in other gypfiles is ...
6 years, 5 months ago (2014-07-11 14:29:49 UTC) #3
blundell
Hi James, Could you review PS1? The only difference between that and PS2 is that ...
6 years, 5 months ago (2014-07-15 14:22:49 UTC) #4
jamesr
ps1 seems ok, although as soon as you have a real target using these things ...
6 years, 5 months ago (2014-07-17 20:53:37 UTC) #5
blundell
Thanks. Yes, as we start to pull in these dependencies from things that are already ...
6 years, 5 months ago (2014-07-25 10:28:18 UTC) #6
jochen (gone - plz use gerrit)
6 years, 4 months ago (2014-07-28 09:23:11 UTC) #7
lgtm

Powered by Google App Engine
This is Rietveld 408576698