Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Issue 376563003: Default caret size of the empty element should match the font size (Closed)

Created:
6 years, 5 months ago by Habib Virji
Modified:
6 years, 5 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Default caret size of the empty element should match the font size Caret size should match with the size of the font. It changes the behavior where default caret size matches size of the box. R=leviw BUG=391215 TEST=Check the size of caret bound for different line height. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178276

Patch Set 1 #

Patch Set 2 : Updated TestExpectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -4 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +13 lines, -0 lines 0 comments Download
A LayoutTests/editing/caret/caret-height.html View 1 chunk +18 lines, -0 lines 0 comments Download
A + LayoutTests/editing/caret/caret-height-expected.txt View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderBoxModelObject.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Habib Virji
A small patch that uses font size instead of line height.
6 years, 5 months ago (2014-07-07 09:44:33 UTC) #1
Habib Virji
On 2014/07/07 09:44:33, Habib Virji wrote: > A small patch that uses font size instead ...
6 years, 5 months ago (2014-07-07 12:28:17 UTC) #2
Habib Virji
On 2014/07/07 09:44:33, Habib Virji wrote: > A small patch that uses font size instead ...
6 years, 5 months ago (2014-07-07 12:28:18 UTC) #3
eae
+ leviw, jparent This seems reasonable to me but let's ask our editing experts. Levi, ...
6 years, 5 months ago (2014-07-08 21:39:12 UTC) #4
Habib Virji
On 2014/07/08 21:39:12, eae wrote: > + leviw, jparent > > This seems reasonable to ...
6 years, 5 months ago (2014-07-14 20:42:03 UTC) #5
leviw_travelin_and_unemployed
LGTM. You'll need to add test expectations for all the failing tests.
6 years, 5 months ago (2014-07-16 04:20:53 UTC) #6
Habib Virji
The CQ bit was checked by habib.virji@samsung.com
6 years, 5 months ago (2014-07-16 12:22:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/habib.virji@samsung.com/376563003/20001
6 years, 5 months ago (2014-07-16 12:23:08 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 13:26:18 UTC) #9
Message was sent while issue was closed.
Change committed as 178276

Powered by Google App Engine
This is Rietveld 408576698