Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Side by Side Diff: src/arm64/macro-assembler-arm64-inl.h

Issue 376553006: Revert "ARM64: Use UntagSmi helpers and clean up assertions." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm64/lithium-codegen-arm64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_ARM64_MACRO_ASSEMBLER_ARM64_INL_H_ 5 #ifndef V8_ARM64_MACRO_ASSEMBLER_ARM64_INL_H_
6 #define V8_ARM64_MACRO_ASSEMBLER_ARM64_INL_H_ 6 #define V8_ARM64_MACRO_ASSEMBLER_ARM64_INL_H_
7 7
8 #include <ctype.h> 8 #include <ctype.h>
9 9
10 #include "src/globals.h" 10 #include "src/globals.h"
(...skipping 1290 matching lines...) Expand 10 before | Expand all | Expand 10 after
1301 1301
1302 1302
1303 void MacroAssembler::InitializeRootRegister() { 1303 void MacroAssembler::InitializeRootRegister() {
1304 ExternalReference roots_array_start = 1304 ExternalReference roots_array_start =
1305 ExternalReference::roots_array_start(isolate()); 1305 ExternalReference::roots_array_start(isolate());
1306 Mov(root, Operand(roots_array_start)); 1306 Mov(root, Operand(roots_array_start));
1307 } 1307 }
1308 1308
1309 1309
1310 void MacroAssembler::SmiTag(Register dst, Register src) { 1310 void MacroAssembler::SmiTag(Register dst, Register src) {
1311 STATIC_ASSERT(kSmiValueSize + kSmiShift == kXRegSizeInBits);
1312 ASSERT(dst.Is64Bits() && src.Is64Bits()); 1311 ASSERT(dst.Is64Bits() && src.Is64Bits());
1313 Lsl(dst, src, kSmiShift); 1312 Lsl(dst, src, kSmiShift);
1314 } 1313 }
1315 1314
1316 1315
1317 void MacroAssembler::SmiTag(Register smi) { SmiTag(smi, smi); } 1316 void MacroAssembler::SmiTag(Register smi) { SmiTag(smi, smi); }
1318 1317
1319 1318
1320 void MacroAssembler::SmiUntag(Register dst, Register src) { 1319 void MacroAssembler::SmiUntag(Register dst, Register src) {
1321 STATIC_ASSERT(kSmiValueSize + kSmiShift == kXRegSizeInBits);
1322 ASSERT(dst.Is64Bits() && src.Is64Bits()); 1320 ASSERT(dst.Is64Bits() && src.Is64Bits());
1323 if (FLAG_enable_slow_asserts) { 1321 if (FLAG_enable_slow_asserts) {
1324 AssertSmi(src); 1322 AssertSmi(src);
1325 } 1323 }
1326 Asr(dst, src, kSmiShift); 1324 Asr(dst, src, kSmiShift);
1327 } 1325 }
1328 1326
1329 1327
1330 void MacroAssembler::SmiUntag(Register smi) { SmiUntag(smi, smi); } 1328 void MacroAssembler::SmiUntag(Register smi) { SmiUntag(smi, smi); }
1331 1329
(...skipping 14 matching lines...) Expand all
1346 UntagMode mode) { 1344 UntagMode mode) {
1347 ASSERT(dst.Is32Bits() && src.Is64Bits()); 1345 ASSERT(dst.Is32Bits() && src.Is64Bits());
1348 if (FLAG_enable_slow_asserts && (mode == kNotSpeculativeUntag)) { 1346 if (FLAG_enable_slow_asserts && (mode == kNotSpeculativeUntag)) {
1349 AssertSmi(src); 1347 AssertSmi(src);
1350 } 1348 }
1351 Scvtf(dst, src, kSmiShift); 1349 Scvtf(dst, src, kSmiShift);
1352 } 1350 }
1353 1351
1354 1352
1355 void MacroAssembler::SmiTagAndPush(Register src) { 1353 void MacroAssembler::SmiTagAndPush(Register src) {
1356 STATIC_ASSERT((kSmiShift == kWRegSizeInBits) && 1354 STATIC_ASSERT((kSmiShift == 32) && (kSmiTag == 0));
1357 (kSmiValueSize == kWRegSizeInBits) &&
1358 (kSmiTag == 0));
1359 Push(src.W(), wzr); 1355 Push(src.W(), wzr);
1360 } 1356 }
1361 1357
1362 1358
1363 void MacroAssembler::SmiTagAndPush(Register src1, Register src2) { 1359 void MacroAssembler::SmiTagAndPush(Register src1, Register src2) {
1364 STATIC_ASSERT((kSmiShift == kWRegSizeInBits) && 1360 STATIC_ASSERT((kSmiShift == 32) && (kSmiTag == 0));
1365 (kSmiValueSize == kWRegSizeInBits) &&
1366 (kSmiTag == 0));
1367 Push(src1.W(), wzr, src2.W(), wzr); 1361 Push(src1.W(), wzr, src2.W(), wzr);
1368 } 1362 }
1369 1363
1370 1364
1371 void MacroAssembler::JumpIfSmi(Register value, 1365 void MacroAssembler::JumpIfSmi(Register value,
1372 Label* smi_label, 1366 Label* smi_label,
1373 Label* not_smi_label) { 1367 Label* not_smi_label) {
1374 STATIC_ASSERT((kSmiTagSize == 1) && (kSmiTag == 0)); 1368 STATIC_ASSERT((kSmiTagSize == 1) && (kSmiTag == 0));
1375 // Check if the tag bit is set. 1369 // Check if the tag bit is set.
1376 if (smi_label) { 1370 if (smi_label) {
(...skipping 330 matching lines...) Expand 10 before | Expand all | Expand 10 after
1707 // characters are reserved for controlling features of the instrumentation. 1701 // characters are reserved for controlling features of the instrumentation.
1708 ASSERT(isprint(marker_name[0]) && isprint(marker_name[1])); 1702 ASSERT(isprint(marker_name[0]) && isprint(marker_name[1]));
1709 1703
1710 InstructionAccurateScope scope(this, 1); 1704 InstructionAccurateScope scope(this, 1);
1711 movn(xzr, (marker_name[1] << 8) | marker_name[0]); 1705 movn(xzr, (marker_name[1] << 8) | marker_name[0]);
1712 } 1706 }
1713 1707
1714 } } // namespace v8::internal 1708 } } // namespace v8::internal
1715 1709
1716 #endif // V8_ARM64_MACRO_ASSEMBLER_ARM64_INL_H_ 1710 #endif // V8_ARM64_MACRO_ASSEMBLER_ARM64_INL_H_
OLDNEW
« no previous file with comments | « src/arm64/lithium-codegen-arm64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698