Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 376553004: Split out tests of private scripts from Internals to PrivateScriptTest (Closed)

Created:
6 years, 5 months ago by haraken
Modified:
6 years, 5 months ago
CC:
arv+blink, blink-reviews, Inactive
Project:
blink
Visibility:
Public.

Description

Split out tests of private scripts from Internals to PrivateScriptTest This is a clean-up CL of Blink-in-JS. Instead of adding more tests about private scripts to Internals, we should have a dedicated IDL file to handle those tests. BUG=341031 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177629

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -215 lines) Patch
M LayoutTests/fast/dom/private_script_unittest.html View 1 chunk +48 lines, -47 lines 0 comments Download
M LayoutTests/fast/dom/private_script_unittest-expected.txt View 1 1 chunk +25 lines, -26 lines 0 comments Download
M Source/core/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/core.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/core.gypi View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/core_generated.gyp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/Internals.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M Source/core/testing/Internals.idl View 2 chunks +5 lines, -25 lines 0 comments Download
D Source/core/testing/Internals.js View 1 chunk +0 lines, -114 lines 0 comments Download
A Source/core/testing/PrivateScriptTest.h View 1 2 1 chunk +28 lines, -0 lines 0 comments Download
A Source/core/testing/PrivateScriptTest.idl View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
A + Source/core/testing/PrivateScriptTest.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
haraken
PTAL
6 years, 5 months ago (2014-07-07 11:14:17 UTC) #1
abarth-chromium
LGTM https://codereview.chromium.org/376553004/diff/20001/Source/core/testing/PrivateScriptTest.h File Source/core/testing/PrivateScriptTest.h (right): https://codereview.chromium.org/376553004/diff/20001/Source/core/testing/PrivateScriptTest.h#newcode13 Source/core/testing/PrivateScriptTest.h:13: class PrivateScriptTest : public RefCountedWillBeGarbageCollected<PrivateScriptTest> { Why not ...
6 years, 5 months ago (2014-07-07 16:03:48 UTC) #2
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 5 months ago (2014-07-08 01:26:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/376553004/40001
6 years, 5 months ago (2014-07-08 01:27:43 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 02:32:27 UTC) #5
Message was sent while issue was closed.
Change committed as 177629

Powered by Google App Engine
This is Rietveld 408576698