Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Issue 376463002: Corrects the regression of [a-z] keys for non-US layouts would have wrong VKEY code if CAPSLOCK is … (Closed)

Created:
6 years, 5 months ago by Shu Chen
Modified:
6 years, 5 months ago
Reviewers:
garykac
CC:
chromium-reviews, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Corrects the regression of [a-z] keys for non-US layouts would have wrong VKEY code if CAPSLOCK is on. For example, Ctrl+A with Caps used to work for FR keyboard, but after cl 357613002, it doesn't work. The root cause is that cl 357613002 tries the remove the modifier states for the xkeyevent for its keysym for [a-z0-9] keys but only considered the shift/altgr states, not capslock & other states. BUG=386066 TEST=Verified on Pixel device. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281694

Patch Set 1 #

Patch Set 2 : fixed test failures. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/events/keycodes/keyboard_code_conversion_x.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Shu Chen
Gary, can you please review this cl for a regression due to the last cl ...
6 years, 5 months ago (2014-07-06 15:32:28 UTC) #1
garykac
lgtm
6 years, 5 months ago (2014-07-07 16:57:01 UTC) #2
Shu Chen
The CQ bit was checked by shuchen@chromium.org
6 years, 5 months ago (2014-07-08 00:51:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shuchen@chromium.org/376463002/1
6 years, 5 months ago (2014-07-08 00:52:49 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-08 04:52:53 UTC) #5
Shu Chen
The CQ bit was checked by shuchen@chromium.org
6 years, 5 months ago (2014-07-08 05:00:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shuchen@chromium.org/376463002/20001
6 years, 5 months ago (2014-07-08 05:01:54 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-08 06:52:34 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 08:09:28 UTC) #9
Message was sent while issue was closed.
Change committed as 281694

Powered by Google App Engine
This is Rietveld 408576698