Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: components/search_engines/default_search_pref_test_util.h

Issue 376413002: Stop using TemplateURLServiceTestUtil to initialize TemplateURLServiceFactory (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix TemplateURLServiceWithoutFallbackTest Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/search_engines.gypi ('k') | components/search_engines/default_search_pref_test_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/search_engines/default_search_pref_test_util.h
diff --git a/chrome/browser/search_engines/template_url_service_test_util.h b/components/search_engines/default_search_pref_test_util.h
similarity index 20%
copy from chrome/browser/search_engines/template_url_service_test_util.h
copy to components/search_engines/default_search_pref_test_util.h
index 83f4fade3c5358b98fe33084610485defe79d318..53484e6a4a844aa0802c124920b4cef915c5bc6b 100644
--- a/chrome/browser/search_engines/template_url_service_test_util.h
+++ b/components/search_engines/default_search_pref_test_util.h
@@ -1,70 +1,22 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright 2014 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_SEARCH_ENGINES_TEMPLATE_URL_SERVICE_TEST_UTIL_H_
-#define CHROME_BROWSER_SEARCH_ENGINES_TEMPLATE_URL_SERVICE_TEST_UTIL_H_
+#ifndef COMPONENTS_SEARCH_ENGINES_DEFAULT_SEARCH_PREF_TEST_UTIL_H_
+#define COMPONENTS_SEARCH_ENGINES_DEFAULT_SEARCH_PREF_TEST_UTIL_H_
#include <string>
#include "base/basictypes.h"
-#include "base/files/scoped_temp_dir.h"
-#include "base/memory/ref_counted.h"
#include "base/memory/scoped_ptr.h"
-#include "base/message_loop/message_loop.h"
-#include "base/strings/string16.h"
-#include "components/search_engines/template_url_service_observer.h"
-#include "content/public/test/test_browser_thread_bundle.h"
+#include "base/values.h"
+#include "components/search_engines/default_search_manager.h"
-class GURL;
-class TemplateURLService;
-class TestingProfile;
-class TestingTemplateURLService;
-class TestingProfile;
-
-// TemplateURLServiceTestUtilBase contains basic API to ease testing of
-// TemplateURLService. User should take care of the infrastructure separately.
-class TemplateURLServiceTestUtilBase : public TemplateURLServiceObserver {
+class DefaultSearchPrefTestUtil {
public:
- TemplateURLServiceTestUtilBase();
- virtual ~TemplateURLServiceTestUtilBase();
-
- void CreateTemplateUrlService();
-
- // TemplateURLServiceObserver implemementation.
- virtual void OnTemplateURLServiceChanged() OVERRIDE;
-
- // Gets the observer count.
- int GetObserverCount();
-
- // Sets the observer count to 0.
- void ResetObserverCount();
-
- // Makes sure the load was successful and sent the correct notification.
- void VerifyLoad();
-
- // Makes the model believe it has been loaded (without actually doing the
- // load). Since this avoids setting the built-in keyword version, the next
- // load will do a merge from prepopulated data.
- void ChangeModelToLoadState();
-
- // Deletes the current model (and doesn't create a new one).
- void ClearModel();
-
- // Creates a new TemplateURLService.
- void ResetModel(bool verify_load);
-
- // Returns the search term from the last invocation of
- // TemplateURLService::SetKeywordSearchTermsForURL and clears the search term.
- base::string16 GetAndClearSearchTerm();
-
- // Set the google base url. |base_url| must be valid.
- void SetGoogleBaseURL(const GURL& base_url) const;
-
- // Set the managed preferences for the default search provider and trigger
- // notification. If |alternate_url| is empty, uses an empty list of alternate
- // URLs, otherwise use a list containing a single entry.
- void SetManagedDefaultSearchPreferences(
+ // Creates a DictionaryValue which can be used as a
+ // kDefaultSearchProviderDataPrefName preference value.
+ static scoped_ptr<base::DictionaryValue> CreateDefaultSearchPreferenceValue(
bool enabled,
const std::string& name,
const std::string& keyword,
@@ -75,48 +27,34 @@ class TemplateURLServiceTestUtilBase : public TemplateURLServiceObserver {
const std::string& alternate_url,
const std::string& search_terms_replacement_key);
+ // Set the managed preferences for the default search provider and trigger
+ // notification. If |alternate_url| is empty, uses an empty list of alternate
+ // URLs, otherwise use a list containing a single entry.
+ template<typename TestingPrefService>
+ static void SetManagedPref(TestingPrefService* pref_service,
+ bool enabled,
+ const std::string& name,
+ const std::string& keyword,
+ const std::string& search_url,
+ const std::string& suggest_url,
+ const std::string& icon_url,
+ const std::string& encodings,
+ const std::string& alternate_url,
+ const std::string& search_terms_replacement_key) {
+ pref_service->SetManagedPref(
+ DefaultSearchManager::kDefaultSearchProviderDataPrefName,
+ CreateDefaultSearchPreferenceValue(
+ enabled, name, keyword, search_url, suggest_url, icon_url,
+ encodings, alternate_url, search_terms_replacement_key).release());
+ }
+
// Remove all the managed preferences for the default search provider and
// trigger notification.
- void RemoveManagedDefaultSearchPreferences();
-
- // Returns the TemplateURLService.
- TemplateURLService* model() const;
-
- // Returns the TestingProfile.
- virtual TestingProfile* profile() const = 0;
-
- private:
- int changed_count_;
-
- DISALLOW_COPY_AND_ASSIGN(TemplateURLServiceTestUtilBase);
-};
-
-// TemplateURLServiceTestUtil sets up TestingProfile, TemplateURLService and
-// required threads.
-class TemplateURLServiceTestUtil : public TemplateURLServiceTestUtilBase {
- public:
- TemplateURLServiceTestUtil();
- virtual ~TemplateURLServiceTestUtil();
-
- // Sets up the data structures for this class (mirroring gtest standard
- // methods).
- void SetUp();
-
- // Cleans up data structures for this class (mirroring gtest standard
- // methods).
- void TearDown();
-
- // Returns the TestingProfile.
- virtual TestingProfile* profile() const OVERRIDE;
-
- private:
- // Needed to make the DeleteOnUIThread trait of WebDataService work
- // properly.
- content::TestBrowserThreadBundle thread_bundle_;
- scoped_ptr<TestingProfile> profile_;
- base::ScopedTempDir temp_dir_;
-
- DISALLOW_COPY_AND_ASSIGN(TemplateURLServiceTestUtil);
+ template<typename TestingPrefService>
+ static void RemoveManagedPref(TestingPrefService* pref_service) {
+ pref_service->RemoveManagedPref(
+ DefaultSearchManager::kDefaultSearchProviderDataPrefName);
+ }
};
-#endif // CHROME_BROWSER_SEARCH_ENGINES_TEMPLATE_URL_SERVICE_TEST_UTIL_H_
+#endif // COMPONENTS_SEARCH_ENGINES_DEFAULT_SEARCH_PREF_TEST_UTIL_H_
« no previous file with comments | « components/search_engines.gypi ('k') | components/search_engines/default_search_pref_test_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698