Issue 376403002: Update size expectations and shared lib expectations after clang switch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 376403002: Update size expectations and shared lib expectations after clang switch (Closed)

Created:
6 years, 5 months ago by Nico

Modified:
6 years, 5 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews, grt+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Update size expectations and shared lib expectations after clang switch BUG=360311 TBR=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282261

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -18 lines)			Patch
	M	chrome/installer/linux/rpm/expected_deps_i386	View		3 chunks	+1 line, -4 lines	0 comments	Download
	M	tools/perf_expectations/perf_expectations.json	View		2 chunks	+14 lines, -14 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nico

I never changed so expectations, please check that part carefully. (The 64bit build was happy ...

6 years, 5 months ago (2014-07-10 05:04:20 UTC) #1

Nico

Committed patchset #1 manually as r282261 (tree was closed).

6 years, 5 months ago (2014-07-10 05:04:48 UTC) #2

Lei Zhang

I'm not qualified to review perf expectations changes. expected_deps lgtm if the bots go green.

6 years, 5 months ago (2014-07-10 18:20:17 UTC) #3

Nico

6 years, 5 months ago (2014-07-10 18:24:54 UTC) #4

Message was sent while issue was closed.

On 2014/07/10 18:20:17, Lei Zhang wrote:
> I'm not qualified to review perf expectations changes.

Pretty sure those are right :-)

> expected_deps lgtm if the bots go green.

The 32bit bot is green at least. Still fighting 64…

Expand Messages | Collapse Messages