Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 376383002: Mojo: Add support for InterfacePtr as a struct member (Closed)

Created:
6 years, 5 months ago by darin (slow to review)
Modified:
6 years, 5 months ago
Reviewers:
DaveMoore
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : retry #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -1 line) Patch
M mojo/public/cpp/bindings/tests/handle_passing_unittest.cc View 3 chunks +27 lines, -0 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/sample_factory.mojom View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/sample_import.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl View 2 chunks +5 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_cpp_generator.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
darin (slow to review)
6 years, 5 months ago (2014-07-10 04:50:10 UTC) #1
DaveMoore
lgtm
6 years, 5 months ago (2014-07-10 23:06:06 UTC) #2
darin (slow to review)
The CQ bit was checked by darin@chromium.org
6 years, 5 months ago (2014-07-10 23:07:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/376383002/1
6 years, 5 months ago (2014-07-10 23:08:31 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-11 01:10:57 UTC) #5
commit-bot: I haz the power
Change committed as 282555
6 years, 5 months ago (2014-07-11 05:12:05 UTC) #6
darin (slow to review)
Trying to land this patch again now that http://crrev.com/283258 has landed.
6 years, 5 months ago (2014-07-15 23:26:06 UTC) #7
darin (slow to review)
The CQ bit was checked by darin@chromium.org
6 years, 5 months ago (2014-07-15 23:26:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/376383002/20001
6 years, 5 months ago (2014-07-15 23:29:57 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 07:44:41 UTC) #10
Message was sent while issue was closed.
Change committed as 283387

Powered by Google App Engine
This is Rietveld 408576698