Chromium Code Reviews| Index: chrome/browser/ssl/ssl_error_classification.h |
| diff --git a/chrome/browser/ssl/ssl_error_classification.h b/chrome/browser/ssl/ssl_error_classification.h |
| index c37ce2e007b820ec55483a50b8fd7de5bda821ad..698657ccb0808bbf5ce1ae6cd9526c6fcd3786fc 100644 |
| --- a/chrome/browser/ssl/ssl_error_classification.h |
| +++ b/chrome/browser/ssl/ssl_error_classification.h |
| @@ -5,18 +5,23 @@ |
| #ifndef CHROME_BROWSER_SSL_SSL_ERROR_CLASSIFICATION_H_ |
| #define CHROME_BROWSER_SSL_SSL_ERROR_CLASSIFICATION_H_ |
| +#include <string> |
| +#include <vector> |
| + |
| #include "base/time/time.h" |
| #include "net/cert/x509_certificate.h" |
| +#include "url/gurl.h" |
| // This class calculates the severity scores for the different type of SSL |
| // errors. |
| class SSLErrorClassification { |
| public: |
| SSLErrorClassification(base::Time current_time, |
| + const GURL& url, |
| const net::X509Certificate& cert); |
| ~SSLErrorClassification(); |
| - // This method checks whether the user clock is in the past or not. |
| + // This method checks whether the system time is in the past. |
| static bool IsUserClockInThePast(base::Time time_now); |
| // This method checks whether the system time is too far in the future or |
| @@ -27,17 +32,58 @@ class SSLErrorClassification { |
| // CERT_DATE_INVALID. |
| float InvalidDateSeverityScore() const; |
| - static void RecordUMAStatistics(bool overridable); |
| + // A method which calculates the severity score when the ssl error is |
| + // CERT_COMMON_NAME_INVALID. |
| + float InvalidCommonNameSeverityScore() const; |
| + |
| + void RecordUMAStatistics(bool overridable, int cert_error); |
| base::TimeDelta TimePassedSinceExpiry() const; |
| private: |
| - FRIEND_TEST_ALL_PREFIXES(SSLErrorClassification, TestDateInvalidScore); |
| + FRIEND_TEST_ALL_PREFIXES(SSLErrorClassificationTest, TestDateInvalidScore); |
| + FRIEND_TEST_ALL_PREFIXES(SSLErrorClassificationTest, TestNameMismatch); |
| + FRIEND_TEST_ALL_PREFIXES(SSLErrorClassificationTest, |
| + TestHostNameHasKnownTLD); |
| + |
| + typedef std::vector<std::string> Tokens; |
| + |
| + // This method checks whether the hostname has a known Top Level Domain or |
| + // not. |
| + static bool IsHostNameKnownTLD(const std::string& host_name); |
| + |
| + // A certificate for bank.com does not work for www.bank.com and vice versa. |
| + // This method checks whteher the error is caused because of "www" difference |
| + // between the host name and any DNS name given in the CN or SAN fields of |
| + // the SSL certificate. |
| + bool IsWWWSubDomainMatch() const; |
| + |
| + // Returns true if |child| is a subdomain of any of the |potential_parents|. |
| + bool NameUnderAnyNames(const Tokens& child, |
| + const std::vector<Tokens>& potential_parents) const; |
| + |
| + // Returns true if any of the |potential_children| is a subdomain of any of |
| + // the |parent|. |
| + bool AnyNamesUnderName(const std::vector<Tokens>& potential_children, |
| + const Tokens& parent) const; |
| + |
| + // This method checks whether the hostname is too broad for the scope of a |
| + // wildcard certificate or not. For e.g. it returns true if the host name of |
| + // the URL is "a.b.example.com" and the DNS name in the CN or SAN field of the |
| + // SSL certificate is "*.example.com". But, it returns false for the hostname |
| + // "b.example.com". |
| + bool IsSubDomainOutsideWildcard(const Tokens& host_name_tokens) const; |
| + bool IsSelfSigned() const; |
| float CalculateScoreTimePassedSinceExpiry() const; |
| + std::vector<Tokens> GetTokenizedDNSNames( |
| + std::vector<std::string>& dns_names) const; |
|
radhikabhar
2014/07/24 18:05:13
I did not use Tokens out here because these are th
|
| + |
| // This stores the current time. |
| base::Time current_time_; |
| + const GURL& request_url_; |
| + |
| // This stores the certificate. |
| const net::X509Certificate& cert_; |
| }; |