Find reasons for the SSL common name invalid error.

chrome/browser/ssl/ssl_blocking_page.cc

Index: chrome/browser/ssl/ssl_blocking_page.cc
diff --git a/chrome/browser/ssl/ssl_blocking_page.cc b/chrome/browser/ssl/ssl_blocking_page.cc
index ca97c2b60a0a90009235bd3716fc0b3b657f2126..be88ba1048b35107f0586bb09838bd6a2dc2310d 100644
--- a/chrome/browser/ssl/ssl_blocking_page.cc
+++ b/chrome/browser/ssl/ssl_blocking_page.cc
@@ -264,8 +264,32 @@ SSLBlockingPage::SSLBlockingPage(
   }
   if (SSLErrorInfo::NetErrorToErrorType(cert_error_) ==
       SSLErrorInfo::CERT_DATE_INVALID) {
-    SSLErrorClassification::RecordUMAStatistics(overridable_ &&
-                                                !strict_enforcement_);
+    SSLErrorClassification ssl_error_classification(

[felt, 2014/07/16 22:47:33]

you should create a single SSLErrorClassification object and call its methods
repeatedly

[radhikabhar, 2014/07/17 01:02:11]

Done.

+        base::Time::NowFromSystemTime(),
+        request_url_,
+        *ssl_info_.cert.get());
+    ssl_error_classification.RecordUMAStatisticsDateInvalid(

[felt, 2014/07/16 23:31:47]

Actually, wouldn't it make more sense to just have one public method
RecordUMAStatistics, then have a switch statement inside of it based on the
error type that does the appropriate UMA stats? that way SSLBlockingPage doesn't
need to handle any of this logic.

[radhikabhar, 2014/07/17 01:02:11]

Done.

+        overridable_ && !strict_enforcement_);
+  }
+
+  if (SSLErrorInfo::NetErrorToErrorType(cert_error_) ==

[felt, 2014/07/16 22:47:33]

you should probably save the error type instead of calling NetErrorToErrorType
every time

[radhikabhar, 2014/07/17 01:02:11]

Done.

+      SSLErrorInfo::CERT_COMMON_NAME_INVALID) {
+    SSLErrorClassification ssl_error_classification
+        (base::Time::NowFromSystemTime(),
+         request_url_,
+         *ssl_info_.cert.get());
+    ssl_error_classification.RecordUMAStatisticsNameInvalid(
+        overridable_ && !strict_enforcement_);
+  }
+
+  if (SSLErrorInfo::NetErrorToErrorType(cert_error_) ==
+      SSLErrorInfo::CERT_AUTHORITY_INVALID) {
+    SSLErrorClassification ssl_error_classification(
+        base::Time::NowFromSystemTime(),
+        request_url_,
+        *ssl_info_.cert.get());
+    ssl_error_classification.RecordUMAStatisticsAuthorityInvalid(
+        overridable_ && !strict_enforcement_);
   }
 
 #if defined(ENABLE_CAPTIVE_PORTAL_DETECTION)