content/shell/browser/shell_devtools_delegate.cc - Issue 376323002: Refactor unix domain socket.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/shell_devtools_delegate.cc

Issue 376323002: Refactor unix domain socket. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make all connect in unittests synchronous. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/shell/browser/shell_devtools_delegate.cc

diff --git a/content/shell/browser/shell_devtools_delegate.cc b/content/shell/browser/shell_devtools_delegate.cc

index d316b2a1c6a1ec8c150ca9e11ad7b2b49e58c319..2a5abe8ad4d26b3e44d6c3f0ad1fdc1b5b84aaa2 100644

--- a/content/shell/browser/shell_devtools_delegate.cc

+++ b/content/shell/browser/shell_devtools_delegate.cc

@@ -52,7 +52,7 @@ net::StreamListenSocketFactory* CreateSocketFactory() {

socket_name = command_line.GetSwitchValueASCII(

switches::kRemoteDebuggingSocketName);

}

- return new net::UnixDomainSocketWithAbstractNamespaceFactory(

+ return new net::UnixDomainListenSocketWithAbstractNamespaceFactory(

socket_name, "", base::Bind(&content::CanUserConnectToDevTools));

#else

// See if the user specified a port on the command line (useful for