Refactor unix domain socket.

net/socket/unix_domain_client_socket_posix.h

Index: net/socket/unix_domain_client_socket_posix.h
diff --git a/net/socket/unix_domain_client_socket_posix.h b/net/socket/unix_domain_client_socket_posix.h
new file mode 100644
index 0000000000000000000000000000000000000000..a4e491db6ab9457c7c86a1411877a1a0b93c4c34
--- /dev/null
+++ b/net/socket/unix_domain_client_socket_posix.h
@@ -0,0 +1,75 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef NET_SOCKET_UNIX_DOMAIN_CLIENT_SOCKET_POSIX_H_
+#define NET_SOCKET_UNIX_DOMAIN_CLIENT_SOCKET_POSIX_H_
+
+#include <string>
+
+#include "base/basictypes.h"
+#include "base/callback.h"

[mmenke, 2014/07/10 19:07:27]

Should be including net/base/completion_callback.h instead.

[byungchul, 2014/07/11 02:56:32]

Done.

+#include "base/macros.h"
+#include "net/base/net_export.h"
+#include "net/socket/stream_socket.h"
+
+namespace net {
+
+class SocketLibevent;
+struct SockaddrStorage;
+
+// A client socket that uses unix domain socket as the transport layer.
+class NET_EXPORT UnixDomainClientSocket : public StreamSocket {
+ public:
+  // Builds a client socket with socket_path. The caller should call Connect()
+  // to connect to a server socket.
+  UnixDomainClientSocket(const std::string& socket_path,
+                         bool use_abstract_namespace);
+  // Builds a client socket with socket libevent which is already connected.
+  // UnixDomainServerSocket uses this after it accepts a connection.
+  explicit UnixDomainClientSocket(scoped_ptr<SocketLibevent> socket);

[mmenke, 2014/07/10 19:07:28]

should include scoped_ptr

[byungchul, 2014/07/11 02:56:33]

Done.

+
+  virtual ~UnixDomainClientSocket();
+
+  // Fills |address| with |socket_path| and its length. For Android or Linux
+  // platform, it supports abstract namespace.

[mmenke, 2014/07/10 19:07:27]

nit:  it->this, namespace->namespaces.

[byungchul, 2014/07/11 02:56:32]

Done.

+  static bool FillAddress(const std::string& socket_path,
+                          bool use_abstract_namespace,
+                          SockaddrStorage* address);
+
+  // StreamSocket implementation.
+  virtual int Connect(const CompletionCallback& callback) OVERRIDE;
+  virtual void Disconnect() OVERRIDE;
+  virtual bool IsConnected() const OVERRIDE;
+  virtual bool IsConnectedAndIdle() const OVERRIDE;
+  virtual int GetPeerAddress(IPEndPoint* address) const OVERRIDE;
+  virtual int GetLocalAddress(IPEndPoint* address) const OVERRIDE;
+  virtual const BoundNetLog& NetLog() const OVERRIDE;
+  virtual void SetSubresourceSpeculation() OVERRIDE;
+  virtual void SetOmniboxSpeculation() OVERRIDE;
+  virtual bool WasEverUsed() const OVERRIDE;
+  virtual bool UsingTCPFastOpen() const OVERRIDE;
+  virtual bool WasNpnNegotiated() const OVERRIDE;
+  virtual NextProto GetNegotiatedProtocol() const OVERRIDE;
+  virtual bool GetSSLInfo(SSLInfo* ssl_info) OVERRIDE;
+
+  // Socket implementation.
+  virtual int Read(IOBuffer* buf, int buf_len,
+                   const CompletionCallback& callback) OVERRIDE;
+  virtual int Write(IOBuffer* buf, int buf_len,
+                    const CompletionCallback& callback) OVERRIDE;
+  virtual int SetReceiveBufferSize(int32 size) OVERRIDE;
+  virtual int SetSendBufferSize(int32 size) OVERRIDE;
+
+ private:
+  const std::string socket_path_;
+  const bool use_abstract_namespace_;
+  scoped_ptr<SocketLibevent> socket_;
+  BoundNetLog netlog_;

[mmenke, 2014/07/10 19:07:27]

These are generally called net_log_

[mmenke, 2014/07/10 19:07:27]

Should include net/base/net_log.h

[mmenke, 2014/07/10 19:07:28]

Should also have a comment that this BoundNetLog just throws away everything.

[byungchul, 2014/07/11 02:56:32]

Done.

[byungchul, 2014/07/11 02:56:33]

Done.

[byungchul, 2014/07/11 02:56:33]

Done.

+
+  DISALLOW_COPY_AND_ASSIGN(UnixDomainClientSocket);
+};
+
+}  // namespace net
+
+#endif  // NET_SOCKET_UNIX_DOMAIN_CLIENT_SOCKET_POSIX_H_