Observatory: Promote function to ServiceObject

runtime/bin/vmservice/client/lib/src/elements/function_ref.dart

Index: runtime/bin/vmservice/client/lib/src/elements/function_ref.dart
diff --git a/runtime/bin/vmservice/client/lib/src/elements/function_ref.dart b/runtime/bin/vmservice/client/lib/src/elements/function_ref.dart
index 5ed629823df55476456b7bd1b1438e21536a6761..32d79ea6c872e2ed2a3f59e479081eeea6504e41 100644
--- a/runtime/bin/vmservice/client/lib/src/elements/function_ref.dart
+++ b/runtime/bin/vmservice/client/lib/src/elements/function_ref.dart
@@ -5,32 +5,11 @@
 library function_ref_element;
 
 import 'package:polymer/polymer.dart';
-import 'package:observatory/service.dart';
 import 'service_ref.dart';
 
 @CustomTag('function-ref')
 class FunctionRefElement extends ServiceRefElement {
   @published bool qualified = true;

[Michael Lippautz (Google), 2014/07/09 20:22:24]

Get rid of 'qualified'?

[Cutch, 2014/07/09 20:43:31]

We can't, it is used in the html template code.

[Michael Lippautz (Google), 2014/07/09 21:02:11]

Misread @published for @observable and did not understand why we would need it.

 
-  void refChanged(oldValue) {
-    super.refChanged(oldValue);
-    notifyPropertyChange(#hasParent, 0, 1);
-    notifyPropertyChange(#hasClass, 0, 1);
-    ServiceMap refMap = ref;
-    isDart = (refMap != null) &&
-             (refMap['kind'] != 'Collected') &&
-             (refMap['kind'] != 'Native') &&
-             (refMap['kind'] != 'Tag') &&
-             (refMap['kind'] != 'Reused');
-    hasParent = (refMap != null && refMap['parent'] != null);
-    hasClass = (refMap != null &&
-                refMap['owner'] != null &&
-                refMap['owner'].serviceType == 'Class');
-  }
-
-  @observable bool hasParent = false;
-  @observable bool hasClass = false;
-  @observable bool isDart = false;
-
   FunctionRefElement.created() : super.created();
 }