chrome/browser/extensions/notifications_apitest.cc - Issue 376253005: Migrate the notification permission to the new common permission classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/notifications_apitest.cc

Issue 376253005: Migrate the notification permission to the new common permission classes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/content_settings/permission_queue_controller.cc ('k') | chrome/browser/notifications/desktop_notification_infobar_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/notifications_apitest.cc

diff --git a/chrome/browser/extensions/notifications_apitest.cc b/chrome/browser/extensions/notifications_apitest.cc

index d7afc99370b5f7e68b728ae68d630a2edc6e964d..5eaa8676908e2d8916f0346318166556bab4668e 100644

--- a/chrome/browser/extensions/notifications_apitest.cc

+++ b/chrome/browser/extensions/notifications_apitest.cc

@@ -5,8 +5,7 @@

#include "chrome/browser/extensions/extension_apitest.h"

#include "chrome/browser/extensions/lazy_background_page_test_util.h"

-#include "chrome/browser/notifications/desktop_notification_service.h"

-#include "chrome/browser/notifications/desktop_notification_service_factory.h"

+#include "chrome/browser/notifications/desktop_notification_profile_util.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser.h"

#include "extensions/browser/process_manager.h"

@@ -40,9 +39,9 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, NotificationsNoPermission) {

}

IN_PROC_BROWSER_TEST_F(ExtensionApiTest, NotificationsHasPermission) {

- DesktopNotificationServiceFactory::GetForProfile(browser()->profile())

- ->GrantPermission(GURL(

- "chrome-extension://peoadpeiejnhkmpaakpnompolbglelel"));

+ DesktopNotificationProfileUtil::GrantPermission(browser()->profile(),

+ GURL("chrome-extension://peoadpeiejnhkmpaakpnompolbglelel"));

ASSERT_TRUE(RunExtensionTest("notifications/has_permission_prefs"))

<< message_;

}