Migrate the notification permission to the new common permission classes.

chrome/browser/content_settings/permission_context_uma_util.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/metrics/histogram.h"
 #include "chrome/browser/content_settings/permission_context_uma_util.h"
 
 namespace {
 
 // Enum for UMA purposes, make sure you update histograms.xml if you add new
 // permission actions. Never delete or reorder an entry; only add new entries
 // immediately before PERMISSION_NUM
 enum PermissionAction {
   GRANTED = 0,
   DENIED = 1,
   DISMISSED = 2,
   IGNORED = 3,
 
   // Always keep this at the end.
   PERMISSION_ACTION_NUM,
 };
 
 // Enum for UMA purposes, make sure you update histograms.xml if you add new
 // permission actions. Never delete or reorder an entry; only add new entries
 // immediately before PERMISSION_NUM
 enum PermissionType {
-  PERMISSION_UNKNOWN,
-  PERMISSION_MIDI_SYSEX,
-  PERMISSION_PUSH_MESSAGING,
+  PERMISSION_UNKNOWN = 0,
+  PERMISSION_MIDI_SYSEX = 1,
+  PERMISSION_PUSH_MESSAGING = 2,
+  PERMISSION_NOTIFICATIONS = 3,
 
   // Always keep this at the end.
   PERMISSION_NUM,
 };
 
 static const char* kMidiUmaKey = "ContentSettings.PermisionActions_MidiSysEx";
 static const char* kPushMessageUmaKey =
     "ContentSettings.PermisionActions_PushMessaging";
+static const char* kNotificationsUmaKey =

[Peter Beverloo, 2014/07/18 10:42:38]

All of these should be |const char[] kFoo = "bar";|. Since they're defined in an
anonymous namespace, they don't have to be declared as |static| either.

That said, we rarely use constants like this to indicate the name of the metric
unless it's being used in several places, which they're not. Why don't just have
the strings in the calls themselves (lines 50, 55 and 60)?

[Miguel Garcia, 2014/07/18 12:27:08]

Done.

+    "ContentSettings.PermisionActions_Notifications";
 
 void RecordPermissionAction(
       ContentSettingsType permission, PermissionAction action) {
   switch (permission) {
       case CONTENT_SETTINGS_TYPE_GEOLOCATION:
         // TODO(miguelg): support geolocation through
         // the generic permission class.
         break;
+      case CONTENT_SETTINGS_TYPE_NOTIFICATIONS:
+        UMA_HISTOGRAM_ENUMERATION(kNotificationsUmaKey,
+                                  action,
+                                  PERMISSION_ACTION_NUM);
+        break;
       case CONTENT_SETTINGS_TYPE_MIDI_SYSEX:
         UMA_HISTOGRAM_ENUMERATION(kMidiUmaKey,
                                   action,
                                   PERMISSION_ACTION_NUM);
         break;
       case CONTENT_SETTINGS_TYPE_PUSH_MESSAGING:
         UMA_HISTOGRAM_ENUMERATION(kPushMessageUmaKey,
                                   action,
                                   PERMISSION_ACTION_NUM);
         break;
 #if defined(OS_ANDROID)
       case CONTENT_SETTINGS_TYPE_PROTECTED_MEDIA_IDENTIFIER:
         // TODO(miguelg): support protected media through
         // the generic permission class.
         break;
 #endif
       default:
         NOTREACHED() << "PERMISSION " << permission << " not accounted for";
     }
 }
 
 void RecordPermissionRequest(
     ContentSettingsType permission) {
   PermissionType type;
   switch (permission) {
+    case CONTENT_SETTINGS_TYPE_NOTIFICATIONS:
+      type = PERMISSION_NOTIFICATIONS;
+      break;
     case CONTENT_SETTINGS_TYPE_MIDI_SYSEX:
       type = PERMISSION_MIDI_SYSEX;
       break;
     case CONTENT_SETTINGS_TYPE_PUSH_MESSAGING:
       type = PERMISSION_PUSH_MESSAGING;
       break;
     default:
       NOTREACHED() << "PERMISSION " << permission << " not accounted for";
       type = PERMISSION_UNKNOWN;
   }
@@ skipping 22 matching lines @@
 
 void PermissionContextUmaUtil::PermissionDismissed(
     ContentSettingsType permission) {
   RecordPermissionAction(permission, DISMISSED);
 }
 
 void PermissionContextUmaUtil::PermissionIgnored(
     ContentSettingsType permission) {
   RecordPermissionAction(permission, IGNORED);
 }