Migrate the notification permission to the new common permission classes.

chrome/browser/chrome_content_browser_client.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROME_CONTENT_BROWSER_CLIENT_H_
 #define CHROME_BROWSER_CHROME_CONTENT_BROWSER_CLIENT_H_
 
 #include <set>
 #include <string>
 #include <utility>
 #include <vector>
 
 #include "base/compiler_specific.h"
 #include "base/gtest_prod_util.h"
+#include "base/memory/weak_ptr.h"
 #include "chrome/common/chrome_version_info.h"
 #include "content/public/browser/content_browser_client.h"
 
 #if defined(OS_ANDROID)
 #include "base/memory/scoped_ptr.h"
 #endif
 
 namespace base {
 class CommandLine;
 }
@@ skipping 263 matching lines @@
       int child_process_id,
       std::vector<content::FileDescriptorInfo>* mappings) OVERRIDE;
 #endif
 #if defined(OS_WIN)
   virtual const wchar_t* GetResourceDllName() OVERRIDE;
   virtual void PreSpawnRenderer(sandbox::TargetPolicy* policy,
                                 bool* success) OVERRIDE;
 #endif
 
  private:
+  // Used as a callback once a permission has been decided.
+  // TODO(peter) remove once the notification callback returns
+  // a boolean.
+  void NotificationPermissionRequested(base::Closure callback, bool result);

[Peter Beverloo, 2014/07/18 10:42:38]

NotificationPermissionRequested doesn't modify |this|, so please make this
const.

[Peter Beverloo, 2014/07/18 10:42:38]

const base::Closure&

[Miguel Garcia, 2014/07/18 12:27:08]

Done.

[Miguel Garcia, 2014/07/18 12:27:08]

Acknowledged.

+
 #if defined(ENABLE_WEBRTC)
   // Copies disable WebRTC encryption switch depending on the channel.
   static void MaybeCopyDisableWebRtcEncryptionSwitch(
       base::CommandLine* to_command_line,
       const base::CommandLine& from_command_line,
       VersionInfo::Channel channel);
 #endif
 
   void FileSystemAccessed(
     const GURL& url,
@@ skipping 29 matching lines @@
       permissions_policy_delegate_;
 
   // The prerender tracker used to determine whether a render process is used
   // for prerendering and an override cookie store must be provided.
   // This needs to be kept as a member rather than just looked up from
   // the profile due to initialization ordering, as well as due to threading.
   // It is initialized on the UI thread when the ResoureDispatcherHost is
   // created. It is used only the IO thread.
   prerender::PrerenderTracker* prerender_tracker_;
 
-   base::WeakPtrFactory<ChromeContentBrowserClient> weak_factory_;
+  // TODO(peter) remove once NotificationPermissionRequested is removed.
+  base::WeakPtrFactory<ChromeContentBrowserClient> weak_factory_;
 
   friend class DisableWebRtcEncryptionFlagTest;
 
   DISALLOW_COPY_AND_ASSIGN(ChromeContentBrowserClient);
 };
 
 }  // namespace chrome
 
 #endif  // CHROME_BROWSER_CHROME_CONTENT_BROWSER_CLIENT_H_