Migrate the notification permission to the new common permission classes.

chrome/browser/chrome_content_browser_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_content_browser_client.h"
 
 #include <set>
 #include <utility>
 #include <vector>
 
@@ skipping 2112 matching lines @@
       }
     }
   }
   if (IsExtensionWithPermissionOrSuggestInConsole(
           APIPermission::kNotification, extension,
           render_frame_host->GetRenderViewHost())) {
     callback.Run();
     return;
   }
 
+  WebContents* web_contents = WebContents::FromRenderFrameHost(
+       render_frame_host);

[Peter Beverloo, 2014/07/18 10:42:38]

nit: four space indent

[Miguel Garcia, 2014/07/18 12:27:08]

Done.

+  int render_process_id = render_frame_host->GetProcess()->GetID();
+  const PermissionRequestID id(render_process_id,

[Peter Beverloo, 2014/07/18 10:42:37]

nit: s/id/request_id/ for consistency.

[Miguel Garcia, 2014/07/18 12:27:08]

Done.

+      web_contents->GetRoutingID(), -1 /* bridge id */,

[Peter Beverloo, 2014/07/18 10:42:37]

nit: one argument a line.

[Miguel Garcia, 2014/07/18 12:27:08]

Done.

+      GURL());
+
   notification_service->RequestPermission(
-      source_origin, render_frame_host, callback);
+      web_contents,
+      id,
+      source_origin,
+      // TODO(peter): plumb user_gesture over IPC
+      true,
+      base::Bind(&ChromeContentBrowserClient::NotificationPermissionRequested,
+                 weak_factory_.GetWeakPtr(), callback));

[Peter Beverloo, 2014/07/18 10:42:37]

nit: |callback| should be on its own line.

[Miguel Garcia, 2014/07/18 12:27:08]

Done.

+
 #else
   NOTIMPLEMENTED();
 #endif
 }
 
 blink::WebNotificationPresenter::Permission
     ChromeContentBrowserClient::CheckDesktopNotificationPermission(
         const GURL& source_origin,
         content::ResourceContext* context,
         int render_process_id) {
@@ skipping 769 matching lines @@
     static const char* const kWebRtcDevSwitchNames[] = {
       switches::kDisableWebRtcEncryption,
     };
     to_command_line->CopySwitchesFrom(from_command_line,
                                       kWebRtcDevSwitchNames,
                                       arraysize(kWebRtcDevSwitchNames));
   }
 }
 #endif  // defined(ENABLE_WEBRTC)
 
+
+void ChromeContentBrowserClient::NotificationPermissionRequested(
+    base::Closure callback, bool result) {
+  callback.Run();
+}
+
 }  // namespace chrome