Issue 376253002: Fix ProfileSyncServiceBookmarksTest on OS_IOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 376253002: Fix ProfileSyncServiceBookmarksTest on OS_IOS. (Closed)

Created:
6 years, 5 months ago by Joao da Silva

Modified:
6 years, 5 months ago

Reviewers:
noyau (Ping after 24h), Andrew T Wilson (Slow), justincohen

CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix ProfileSyncServiceBookmarksTest on OS_IOS. This change upstreams the downstream fixes to this test, so that this file doesn't need to be forked for iOS anymore. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282352

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -3 lines)			Patch
	M	chrome/browser/sync/profile_sync_service_bookmark_unittest.cc	View		3 chunks	+16 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Joao da Silva

This is upstreaming the downstream changes: https://chromereviews.googleplex.com/59867020/ https://chromereviews.googleplex.com/57887017/ The tests pass on iOS after these ...

6 years, 5 months ago (2014-07-09 15:58:04 UTC) #1

Joao da Silva

The downstream CLs have landed, going to land this too.

6 years, 5 months ago (2014-07-10 12:38:16 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/376253002/1

6 years, 5 months ago (2014-07-10 12:39:15 UTC) #5

Message was sent while issue was closed.

Change committed as 282352

Expand Messages | Collapse Messages