src/ic.cc - Issue 376233002: Introduce a PrototypeIterator class and use it for prototype access

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic.cc

Issue 376233002: Introduce a PrototypeIterator class and use it for prototype access (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: updates Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ic.cc

diff --git a/src/ic.cc b/src/ic.cc

index a9c53ba0a15b7f334f52af973bfeb67da01fce81..d6f7cc46470f12ef552c3adecdf2118391a6d733 100644

--- a/src/ic.cc

+++ b/src/ic.cc

@@ -11,6 +11,7 @@

#include "src/conversions.h"

#include "src/execution.h"

#include "src/ic-inl.h"

+#include "src/prototype.h"

#include "src/runtime.h"

#include "src/stub-cache.h"

@@ -248,7 +249,8 @@ bool IC::TryRemoveInvalidPrototypeDependentStub(Handle<Object> receiver,

break;

case PROTOTYPE_MAP:

// IC::GetCodeCacheHolder is not applicable.

- if (receiver->GetPrototype(isolate())->IsNull()) return false;

+ PrototypeIterator iter(isolate(), receiver);

+ if (iter.GetCurrent()->IsNull()) return false;

Toon Verwaest 2014/07/11 09:41:28 IsAtEnd?

break;

}

« src/builtins.cc ('K') | « src/builtins.cc ('k') | src/ic-inl.h » ('j') | src/objects.cc » ('J')