Refactor ScriptData class for cached compile data.

src/preparse-data.h

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_PREPARSE_DATA_H_
 #define V8_PREPARSE_DATA_H_
 
 #include "src/allocation.h"
 #include "src/hashmap.h"
 #include "src/preparse-data-format.h"
@@ skipping 101 matching lines @@
   int literals_;
   int properties_;
   StrictMode strict_mode_;
   // For error messages.
   const char* message_;
   const char* argument_opt_;
   bool is_reference_error_;
 };
 
 
+class ScriptData;

[vogelheim, 2014/07/10 10:05:32]

stlye nitpick: Forward declarations near always follow the #includes and precede
actual class definitions. Not sure if the style guide demands it, but it's
certainly common.

[Yang, 2014/07/10 10:27:58]

Done.

+
+
 class CompleteParserRecorder : public ParserRecorder {
  public:
   struct Key {
     bool is_one_byte;
     Vector<const byte> literal_bytes;
   };
 
   CompleteParserRecorder();
   virtual ~CompleteParserRecorder() {}
 
@@ skipping 10 matching lines @@
   }
 
   // Logs an error message and marks the log as containing an error.
   // Further logging will be ignored, and ExtractData will return a vector
   // representing the error only.
   virtual void LogMessage(int start,
                           int end,
                           const char* message,
                           const char* argument_opt,
                           bool is_reference_error_);
-  Vector<unsigned> ExtractData();
+  ScriptData* GetScriptData();
+
+  bool HasError() {
+    return static_cast<bool>(preamble_[PreparseDataConstants::kHasErrorOffset]);
+  }
+  Vector<unsigned> ErrorMessageData() {
+    ASSERT(HasError());
+    return function_store_.ToVector();
+  }
 
  private:
-  bool has_error() {
-    return static_cast<bool>(preamble_[PreparseDataConstants::kHasErrorOffset]);
-  }
-
   void WriteString(Vector<const char> str);
 
   // Write a non-negative number to the symbol store.
   void WriteNumber(int number);
 
   Collector<unsigned> function_store_;
   unsigned preamble_[PreparseDataConstants::kHeaderSize];
 
 #ifdef DEBUG
   int prev_start_;
 #endif
 };
 
 
 } }  // namespace v8::internal.
 
 #endif  // V8_PREPARSE_DATA_H_