DevTools: Make FrameConsole methods accept ConsoleMessage objects.

Source/core/inspector/InspectorTimelineAgent.cpp

Index: Source/core/inspector/InspectorTimelineAgent.cpp
diff --git a/Source/core/inspector/InspectorTimelineAgent.cpp b/Source/core/inspector/InspectorTimelineAgent.cpp
index 18e17a843e3c36ebbbdd5e537210d56fc80eda00..20353b47166295317e01e90d3c321a06274c6596 100644
--- a/Source/core/inspector/InspectorTimelineAgent.cpp
+++ b/Source/core/inspector/InspectorTimelineAgent.cpp
@@ -37,6 +37,7 @@
 #include "core/frame/FrameHost.h"
 #include "core/frame/FrameView.h"
 #include "core/frame/LocalFrame.h"
+#include "core/inspector/ConsoleMessage.h"
 #include "core/inspector/IdentifiersFactory.h"
 #include "core/inspector/InspectorClient.h"
 #include "core/inspector/InspectorCounters.h"
@@ -412,7 +413,7 @@ void InspectorTimelineAgent::innerStop(bool fromConsole)
 
     for (size_t i = 0; i < m_consoleTimelines.size(); ++i) {
         String message = String::format("Timeline '%s' terminated.", m_consoleTimelines[i].utf8().data());
-        mainFrame()->console().addMessage(JSMessageSource, DebugMessageLevel, message);
+        mainFrame()->console().addMessage(ConsoleMessage::create(JSMessageSource, DebugMessageLevel, message));
     }
     m_consoleTimelines.clear();
 
@@ -776,7 +777,9 @@ void InspectorTimelineAgent::consoleTimeline(ExecutionContext* context, const St
 
     String message = String::format("Timeline '%s' started.", title.utf8().data());
 
-    mainFrame()->console().addMessage(JSMessageSource, DebugMessageLevel, message, String(), 0, 0, nullptr, scriptState);
+    RefPtr<ConsoleMessage> consoleMessage = ConsoleMessage::create(JSMessageSource, DebugMessageLevel, message);
+    consoleMessage->setScriptState(scriptState);
+    mainFrame()->console().addMessage(consoleMessage.release());
     m_consoleTimelines.append(title);
     if (!isStarted()) {
         innerStart();
@@ -794,7 +797,9 @@ void InspectorTimelineAgent::consoleTimelineEnd(ExecutionContext* context, const
     size_t index = m_consoleTimelines.find(title);
     if (index == kNotFound) {
         String message = String::format("Timeline '%s' was not started.", title.utf8().data());
-        mainFrame()->console().addMessage(JSMessageSource, DebugMessageLevel, message, String(), 0, 0, nullptr, scriptState);
+        RefPtr<ConsoleMessage> consoleMessage = ConsoleMessage::create(JSMessageSource, DebugMessageLevel, message);
+        consoleMessage->setScriptState(scriptState);
+        mainFrame()->console().addMessage(consoleMessage.release());
         return;
     }
 
@@ -805,7 +810,9 @@ void InspectorTimelineAgent::consoleTimelineEnd(ExecutionContext* context, const
         unwindRecordStack();
         innerStop(true);
     }
-    mainFrame()->console().addMessage(JSMessageSource, DebugMessageLevel, message, String(), 0, 0, nullptr, scriptState);
+    RefPtr<ConsoleMessage> consoleMessage = ConsoleMessage::create(JSMessageSource, DebugMessageLevel, message);
+    consoleMessage->setScriptState(scriptState);

[aandrey, 2014/07/24 14:05:52]

maybe override ConsoleMessage::create instead of these setters (depending on the
number of possible combinations)?

[kozyatinskiy1, 2014/07/25 09:58:23]

We discuss this with @vsevik. There are many calls in the code with base
arguments: source, level, msg, location. And there are 2-3 calls with
scriptState, ~5 calls with callStack, ~3-4 calls with requestIdentifier in
various combinations.

+    mainFrame()->console().addMessage(consoleMessage.release());
 }
 
 void InspectorTimelineAgent::domContentLoadedEventFired(LocalFrame* frame)