Source/web/WebLocalFrameImpl.cpp - Issue 376213002: DevTools: Make FrameConsole methods accept ConsoleMessage objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebLocalFrameImpl.cpp

Issue 376213002: DevTools: Make FrameConsole methods accept ConsoleMessage objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@scriptFailedToParse

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebLocalFrameImpl.cpp

diff --git a/Source/web/WebLocalFrameImpl.cpp b/Source/web/WebLocalFrameImpl.cpp

index 1e5f9c60c0715e9ff3513bfe192d2cd2355adebd..eb2f013d1ae540197d06363545bdebb94288c831 100644

--- a/Source/web/WebLocalFrameImpl.cpp

+++ b/Source/web/WebLocalFrameImpl.cpp

@@ -109,6 +109,7 @@

#include "core/html/HTMLInputElement.h"

#include "core/html/HTMLLinkElement.h"

#include "core/html/PluginDocument.h"

+#include "core/inspector/ConsoleMessage.h"

#include "core/inspector/InspectorController.h"

#include "core/inspector/ScriptCallStack.h"

#include "core/loader/DocumentLoader.h"

@@ -749,7 +750,7 @@ void WebLocalFrameImpl::addMessageToConsole(const WebConsoleMessage& message)

return;

}

- frame()->document()->addConsoleMessage(OtherMessageSource, webCoreMessageLevel, message.text);

+ frame()->document()->addConsoleMessage(ConsoleMessage::create(OtherMessageSource, webCoreMessageLevel, message.text));

}

void WebLocalFrameImpl::collectGarbage()

« Source/core/inspector/ConsoleMessage.h ('K') | « Source/web/ServiceWorkerGlobalScopeProxy.cpp ('k') | Source/web/WebSharedWorkerImpl.h » ('j') | no next file with comments »