Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp - Issue 376213002: DevTools: Make FrameConsole methods accept ConsoleMessage objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp

Issue 376213002: DevTools: Make FrameConsole methods accept ConsoleMessage objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@scriptFailedToParse

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/inspector/ConsoleMessage.h ('K') | « Source/modules/serviceworkers/ServiceWorkerGlobalScope.h ('k') | Source/modules/websockets/MainThreadWebSocketChannel.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp

diff --git a/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp b/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp

index 9551b55a49d8117937d37bb59e7ebb39969954df..e573332bd58c9aedc1e0aeb79da31c5a195c77ab 100644

--- a/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp

+++ b/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp

@@ -33,6 +33,7 @@

#include "bindings/core/v8/ScriptPromise.h"

#include "bindings/core/v8/ScriptState.h"

#include "bindings/core/v8/V8ThrowException.h"

+#include "core/inspector/ConsoleMessage.h"

#include "core/inspector/ScriptCallStack.h"

#include "core/workers/WorkerClients.h"

#include "core/workers/WorkerThreadStartupData.h"

@@ -119,10 +120,11 @@ void ServiceWorkerGlobalScope::trace(Visitor* visitor)

WorkerGlobalScope::trace(visitor);

}

-void ServiceWorkerGlobalScope::logExceptionToConsole(const String& errorMessage, const String& sourceURL, int lineNumber, int columnNumber, PassRefPtrWillBeRawPtr<ScriptCallStack> callStack)

+void ServiceWorkerGlobalScope::logExceptionToConsole(PassRefPtrWillBeRawPtr<ConsoleMessage> prpMessage)

{

- WorkerGlobalScope::logExceptionToConsole(errorMessage, sourceURL, lineNumber, columnNumber, callStack);

- addMessageToWorkerConsole(JSMessageSource, ErrorMessageLevel, errorMessage, sourceURL, lineNumber, callStack, 0);

+ RefPtr<ConsoleMessage> message = prpMessage;

+ WorkerGlobalScope::logExceptionToConsole(message);

+ addMessageToWorkerConsole(message.release());

}

} // namespace WebCore