Source/core/frame/ConsoleBase.cpp - Issue 376213002: DevTools: Make FrameConsole methods accept ConsoleMessage objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/ConsoleBase.cpp

Issue 376213002: DevTools: Make FrameConsole methods accept ConsoleMessage objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@scriptFailedToParse

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/frame/ConsoleBase.cpp

diff --git a/Source/core/frame/ConsoleBase.cpp b/Source/core/frame/ConsoleBase.cpp

index 82c1df17befecb8d632411cf1cd54d301466e5f2..57911ddb28d3fd258dc5ac128e532c05c6bb7fe0 100644

--- a/Source/core/frame/ConsoleBase.cpp

+++ b/Source/core/frame/ConsoleBase.cpp

@@ -159,7 +159,7 @@ void ConsoleBase::groupCollapsed(ScriptState* scriptState, PassRefPtrWillBeRawPt

void ConsoleBase::groupEnd()

{

- InspectorInstrumentation::addMessageToConsole(context(), ConsoleAPIMessageSource, EndGroupMessageType, LogMessageLevel, String(), nullptr);

+ InspectorInstrumentation::addMessageToConsole(context(), ConsoleAPIMessageSource, EndGroupMessageType, LogMessageLevel, String(), nullptr, nullptr);

}

void ConsoleBase::internalAddMessage(MessageType type, MessageLevel level, ScriptState* scriptState, PassRefPtrWillBeRawPtr<ScriptArguments> scriptArguments, bool acceptNoArguments, bool printTrace)

« no previous file with comments | « Source/core/fetch/ResourceFetcher.cpp ('k') | Source/core/frame/FrameConsole.h » ('j') | Source/core/inspector/ConsoleMessage.h » ('J')