Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: Source/core/inspector/InspectorConsoleAgent.h

Issue 376213002: DevTools: Make FrameConsole methods accept ConsoleMessage objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@scriptFailedToParse
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 11 matching lines...) Expand all
22 * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 22 * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
23 */ 23 */
24 24
25 #ifndef InspectorConsoleAgent_h 25 #ifndef InspectorConsoleAgent_h
26 #define InspectorConsoleAgent_h 26 #define InspectorConsoleAgent_h
27 27
28 #include "bindings/core/v8/ScriptState.h" 28 #include "bindings/core/v8/ScriptState.h"
29 #include "bindings/core/v8/ScriptString.h" 29 #include "bindings/core/v8/ScriptString.h"
30 #include "core/InspectorFrontend.h" 30 #include "core/InspectorFrontend.h"
31 #include "core/inspector/ConsoleAPITypes.h" 31 #include "core/inspector/ConsoleAPITypes.h"
32 #include "core/inspector/ConsoleMessage.h"
32 #include "core/inspector/InspectorBaseAgent.h" 33 #include "core/inspector/InspectorBaseAgent.h"
33 #include "core/frame/ConsoleTypes.h" 34 #include "core/frame/ConsoleTypes.h"
34 #include "wtf/Forward.h" 35 #include "wtf/Forward.h"
35 #include "wtf/HashCountedSet.h" 36 #include "wtf/HashCountedSet.h"
36 #include "wtf/HashMap.h" 37 #include "wtf/HashMap.h"
37 #include "wtf/Noncopyable.h" 38 #include "wtf/Noncopyable.h"
38 #include "wtf/Vector.h" 39 #include "wtf/Vector.h"
39 #include "wtf/text/StringHash.h" 40 #include "wtf/text/StringHash.h"
40 41
41 namespace blink { 42 namespace blink {
42 43
43 class InspectorConsoleMessage;
44 class DocumentLoader; 44 class DocumentLoader;
45 class LocalDOMWindow; 45 class LocalDOMWindow;
46 class LocalFrame; 46 class LocalFrame;
47 class InspectorConsoleMessage;
47 class InspectorFrontend; 48 class InspectorFrontend;
48 class InjectedScriptManager; 49 class InjectedScriptManager;
49 class InspectorTimelineAgent; 50 class InspectorTimelineAgent;
50 class InstrumentingAgents; 51 class InstrumentingAgents;
51 class ResourceError; 52 class ResourceError;
52 class ResourceLoader; 53 class ResourceLoader;
53 class ResourceResponse; 54 class ResourceResponse;
54 class ScriptArguments; 55 class ScriptArguments;
55 class ScriptCallStack; 56 class ScriptCallStack;
56 class ScriptProfile; 57 class ScriptProfile;
(...skipping 13 matching lines...) Expand all
70 virtual void disable(ErrorString*) OVERRIDE FINAL; 71 virtual void disable(ErrorString*) OVERRIDE FINAL;
71 virtual void clearMessages(ErrorString*) OVERRIDE; 72 virtual void clearMessages(ErrorString*) OVERRIDE;
72 bool enabled() { return m_enabled; } 73 bool enabled() { return m_enabled; }
73 void reset(); 74 void reset();
74 75
75 virtual void setFrontend(InspectorFrontend*) OVERRIDE FINAL; 76 virtual void setFrontend(InspectorFrontend*) OVERRIDE FINAL;
76 virtual void clearFrontend() OVERRIDE FINAL; 77 virtual void clearFrontend() OVERRIDE FINAL;
77 virtual void restore() OVERRIDE FINAL; 78 virtual void restore() OVERRIDE FINAL;
78 79
79 void addConsoleAPIMessageToConsole(MessageType, MessageLevel, const String& message, ScriptState*, PassRefPtrWillBeRawPtr<ScriptArguments>, unsigned long re questIdentifier = 0); 80 void addConsoleAPIMessageToConsole(MessageType, MessageLevel, const String& message, ScriptState*, PassRefPtrWillBeRawPtr<ScriptArguments>, unsigned long re questIdentifier = 0);
80 void addMessageToConsole(MessageSource, MessageType, MessageLevel, const Str ing& message, const String& scriptId, unsigned lineNumber, unsigned columnNumber = 0, ScriptState* = 0, unsigned long requestIdentifier = 0); 81 void addMessageToConsole(PassRefPtr<ConsoleMessage>);
81
82 // FIXME: Remove once we no longer generate stacks outside of Inspector.
83 void addMessageToConsole(MessageSource, MessageType, MessageLevel, const Str ing& message, PassRefPtrWillBeRawPtr<ScriptCallStack>, unsigned long requestIden tifier = 0);
84 82
85 Vector<unsigned> consoleMessageArgumentCounts(); 83 Vector<unsigned> consoleMessageArgumentCounts();
86 84
87 void consoleTime(ExecutionContext*, const String& title); 85 void consoleTime(ExecutionContext*, const String& title);
88 void consoleTimeEnd(ExecutionContext*, const String& title, ScriptState*); 86 void consoleTimeEnd(ExecutionContext*, const String& title, ScriptState*);
89 void consoleTimeline(ExecutionContext*, const String& title, ScriptState*); 87 void consoleTimeline(ExecutionContext*, const String& title, ScriptState*);
90 void consoleTimelineEnd(ExecutionContext*, const String& title, ScriptState* ); 88 void consoleTimelineEnd(ExecutionContext*, const String& title, ScriptState* );
91 89
92 void consoleCount(ScriptState*, PassRefPtrWillBeRawPtr<ScriptArguments>); 90 void consoleCount(ScriptState*, PassRefPtrWillBeRawPtr<ScriptArguments>);
93 91
(...skipping 23 matching lines...) Expand all
117 HashMap<String, double> m_times; 115 HashMap<String, double> m_times;
118 bool m_enabled; 116 bool m_enabled;
119 private: 117 private:
120 static int s_enabledAgentCount; 118 static int s_enabledAgentCount;
121 }; 119 };
122 120
123 } // namespace blink 121 } // namespace blink
124 122
125 123
126 #endif // !defined(InspectorConsoleAgent_h) 124 #endif // !defined(InspectorConsoleAgent_h)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698