chrome/browser/bookmarks/chrome_bookmark_client.h - Issue 376203002: Fixed use-after-free in LoadCallback in bookmark_storage.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/bookmarks/chrome_bookmark_client.h

Issue 376203002: Fixed use-after-free in LoadCallback in bookmark_storage.cc (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix circular reference Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/bookmarks/chrome_bookmark_client.h

diff --git a/chrome/browser/bookmarks/chrome_bookmark_client.h b/chrome/browser/bookmarks/chrome_bookmark_client.h

index e559d3753d08755d396a4433fef5dded7fa73cec..ee9d380afbdc2b020d77a95f5861826b1bf09ec2 100644

--- a/chrome/browser/bookmarks/chrome_bookmark_client.h

+++ b/chrome/browser/bookmarks/chrome_bookmark_client.h

@@ -9,7 +9,6 @@

#include "base/deferred_sequenced_task_runner.h"

#include "base/macros.h"

-#include "base/memory/ref_counted.h"

#include "components/bookmarks/browser/base_bookmark_model_observer.h"

#include "components/bookmarks/browser/bookmark_client.h"

#include "components/policy/core/browser/managed_bookmarks_tracker.h"

@@ -83,7 +82,6 @@ class ChromeBookmarkClient : public bookmarks::BookmarkClient,

// Helper for GetLoadExtraNodesCallback().

static bookmarks::BookmarkPermanentNodeList LoadExtraNodes(

- const scoped_refptr<base::DeferredSequencedTaskRunner>& profile_io_runner,

scoped_ptr<BookmarkPermanentNode> managed_node,

scoped_ptr<base::ListValue> initial_managed_bookmarks,

int64* next_node_id);