Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 376193003: Fix race condition in gyp/ninja builds. (Closed)

Created:
6 years, 5 months ago by simonb (inactive)
Modified:
6 years, 5 months ago
CC:
chromium-reviews, aurimas (slooooooooow)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix race condition in gyp/ninja builds. A race can exist where two build targets build the same libchrome. It can manifest as: .../arm-linux-androideabi-objcopy: error: the input file '.../libchrome.2085.0.so' is empty Move the temporary directory used to transfer stripped files between the strip and pack actions from <(SHARED_INTERMEDIATE_DIR) to <(intermediate_dir). Also, remove nugatory inter-action dependency, and make actions previously consuming <(strip_stamp) consume <(pack_arm_relocations_stamp) instead. BUG=392417 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282118

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase to ToT. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M build/java_apk.gypi View 1 2 4 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
simonb (inactive)
6 years, 5 months ago (2014-07-09 14:12:14 UTC) #1
Andrew Hayden (chromium.org)
LGTM!
6 years, 5 months ago (2014-07-09 14:21:46 UTC) #2
simonb (inactive)
The CQ bit was checked by simonb@chromium.org
6 years, 5 months ago (2014-07-09 14:52:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonb@chromium.org/376193003/1
6 years, 5 months ago (2014-07-09 14:53:09 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-09 15:18:36 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-09 15:19:54 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/builds/27161) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/26495)
6 years, 5 months ago (2014-07-09 15:19:54 UTC) #7
Andrew Hayden (chromium.org)
LGTM again!
6 years, 5 months ago (2014-07-09 16:28:27 UTC) #8
simonb (inactive)
The CQ bit was checked by simonb@chromium.org
6 years, 5 months ago (2014-07-09 16:28:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonb@chromium.org/376193003/40001
6 years, 5 months ago (2014-07-09 16:29:29 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 20:51:26 UTC) #11
Message was sent while issue was closed.
Change committed as 282118

Powered by Google App Engine
This is Rietveld 408576698