Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1248)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 376193002: Move UserImage to user_manager (Closed)

Created:
6 years, 5 months ago by Nikita (slow)
Modified:
6 years, 5 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, pam+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Move UserImage to user_manager BUG=387614 TBR=brettw,danakj Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282342

Patch Set 1 #

Patch Set 2 : bring back gfx::ImageSkia #

Total comments: 4

Patch Set 3 : add ui/gfx dep #

Total comments: 2

Patch Set 4 : add url dep #

Patch Set 5 : avatar > user_image #

Patch Set 6 : rebase #

Patch Set 7 : rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -275 lines) Patch
M chrome/browser/chromeos/extensions/wallpaper_private_api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.cc View 1 2 3 4 5 6 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screens/user_image_screen.cc View 1 2 3 4 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/users/avatar/mock_user_image_manager.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/chromeos/login/users/avatar/user_image.h View 1 chunk +0 lines, -83 lines 0 comments Download
D chrome/browser/chromeos/login/users/avatar/user_image.cc View 1 chunk +0 lines, -101 lines 0 comments Download
M chrome/browser/chromeos/login/users/avatar/user_image_loader.h View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/users/avatar/user_image_loader.cc View 1 2 3 4 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/users/avatar/user_image_manager.h View 1 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/users/avatar/user_image_manager_browsertest.cc View 1 2 3 4 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.h View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc View 1 2 3 4 11 chunks +24 lines, -19 lines 0 comments Download
M chrome/browser/chromeos/login/users/fake_user_manager.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/users/mock_user_manager.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/users/user.h View 1 2 3 4 5 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/users/user.cc View 1 2 3 4 5 6 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h View 1 2 3 4 9 chunks +17 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc View 1 2 3 4 5 6 10 chunks +14 lines, -12 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M components/user_manager.gypi View 1 2 3 4 5 2 chunks +5 lines, -0 lines 0 comments Download
M components/user_manager/DEPS View 1 2 3 1 chunk +3 lines, -0 lines 1 comment Download
A + components/user_manager/user_image/user_image.h View 1 2 3 4 2 chunks +7 lines, -6 lines 0 comments Download
A + components/user_manager/user_image/user_image.cc View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
Nikita (slow)
6 years, 5 months ago (2014-07-09 13:46:59 UTC) #1
Nikita (slow)
bshe@ for chrome/browser/chromeos/extensions/wallpaper_private_api.cc blundell@ for components/user_manager.gypi
6 years, 5 months ago (2014-07-09 13:53:10 UTC) #2
blundell
https://codereview.chromium.org/376193002/diff/20001/components/user_manager.gypi File components/user_manager.gypi (right): https://codereview.chromium.org/376193002/diff/20001/components/user_manager.gypi#newcode24 components/user_manager.gypi:24: '../skia/skia.gyp:skia', this should have a ui dependency.
6 years, 5 months ago (2014-07-09 13:57:04 UTC) #3
Nikita (slow)
antrim@: please review whole CL.
6 years, 5 months ago (2014-07-09 13:57:44 UTC) #4
Nikita (slow)
https://codereview.chromium.org/376193002/diff/20001/components/user_manager.gypi File components/user_manager.gypi (right): https://codereview.chromium.org/376193002/diff/20001/components/user_manager.gypi#newcode24 components/user_manager.gypi:24: '../skia/skia.gyp:skia', On 2014/07/09 13:57:04, blundell wrote: > this should ...
6 years, 5 months ago (2014-07-09 14:18:03 UTC) #5
blundell
//components LGTM with nit https://codereview.chromium.org/376193002/diff/40001/components/user_manager/avatar/user_image.h File components/user_manager/avatar/user_image.h (right): https://codereview.chromium.org/376193002/diff/40001/components/user_manager/avatar/user_image.h#newcode13 components/user_manager/avatar/user_image.h:13: #include "url/gurl.h" you should also ...
6 years, 5 months ago (2014-07-09 14:22:22 UTC) #6
Nikita (slow)
https://codereview.chromium.org/376193002/diff/40001/components/user_manager/avatar/user_image.h File components/user_manager/avatar/user_image.h (right): https://codereview.chromium.org/376193002/diff/40001/components/user_manager/avatar/user_image.h#newcode13 components/user_manager/avatar/user_image.h:13: #include "url/gurl.h" On 2014/07/09 14:22:22, blundell wrote: > you ...
6 years, 5 months ago (2014-07-09 14:44:38 UTC) #7
Denis Kuznetsov (DE-MUC)
https://chromiumcodereview.appspot.com/376193002/diff/20001/chrome/browser/chromeos/login/users/avatar/mock_user_image_manager.h File chrome/browser/chromeos/login/users/avatar/mock_user_image_manager.h (right): https://chromiumcodereview.appspot.com/376193002/diff/20001/chrome/browser/chromeos/login/users/avatar/mock_user_image_manager.h#newcode12 chrome/browser/chromeos/login/users/avatar/mock_user_image_manager.h:12: #include "components/user_manager/avatar/user_image.h" Could you get replace "avatar" with "user_manager" ...
6 years, 5 months ago (2014-07-09 15:56:35 UTC) #8
Nikita (slow)
https://chromiumcodereview.appspot.com/376193002/diff/20001/chrome/browser/chromeos/login/users/avatar/mock_user_image_manager.h File chrome/browser/chromeos/login/users/avatar/mock_user_image_manager.h (right): https://chromiumcodereview.appspot.com/376193002/diff/20001/chrome/browser/chromeos/login/users/avatar/mock_user_image_manager.h#newcode12 chrome/browser/chromeos/login/users/avatar/mock_user_image_manager.h:12: #include "components/user_manager/avatar/user_image.h" On 2014/07/09 15:56:35, Denis Kuznetsov wrote: > ...
6 years, 5 months ago (2014-07-09 16:15:01 UTC) #9
Denis Kuznetsov (DE-MUC)
lgtm
6 years, 5 months ago (2014-07-09 18:22:20 UTC) #10
Nikita (slow)
OWNERS review of new libs added to components/user_manager/DEPS danakj@ +ui/gfx brettw@ +third_party/skia/include +url
6 years, 5 months ago (2014-07-10 09:54:06 UTC) #11
blundell
On 2014/07/10 09:54:06, Nikita Kostylev wrote: > OWNERS review of new libs added to > ...
6 years, 5 months ago (2014-07-10 09:54:39 UTC) #12
Nikita (slow)
On 2014/07/10 09:54:39, blundell wrote: > On 2014/07/10 09:54:06, Nikita Kostylev wrote: > > OWNERS ...
6 years, 5 months ago (2014-07-10 10:03:14 UTC) #13
Nikita (slow)
The CQ bit was checked by nkostylev@chromium.org
6 years, 5 months ago (2014-07-10 10:03:30 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/376193002/130001
6 years, 5 months ago (2014-07-10 10:04:04 UTC) #15
commit-bot: I haz the power
Change committed as 282342
6 years, 5 months ago (2014-07-10 16:13:48 UTC) #16
bshe
On 2014/07/10 16:13:48, I haz the power (commit-bot) wrote: > Change committed as 282342 lgtm ...
6 years, 5 months ago (2014-07-10 21:33:16 UTC) #17
danakj
https://codereview.chromium.org/376193002/diff/130001/components/user_manager/DEPS File components/user_manager/DEPS (right): https://codereview.chromium.org/376193002/diff/130001/components/user_manager/DEPS#newcode3 components/user_manager/DEPS:3: "+ui/gfx", you need all of ui/gfx?
6 years, 5 months ago (2014-07-10 21:54:37 UTC) #18
Nikita (slow)
On 2014/07/10 21:54:37, danakj wrote: > https://codereview.chromium.org/376193002/diff/130001/components/user_manager/DEPS > File components/user_manager/DEPS (right): > > https://codereview.chromium.org/376193002/diff/130001/components/user_manager/DEPS#newcode3 > ...
6 years, 5 months ago (2014-07-11 06:29:34 UTC) #19
Nikita (slow)
6 years, 5 months ago (2014-07-12 18:37:50 UTC) #20
Message was sent while issue was closed. 
On 2014/07/11 06:29:34, Nikita Kostylev wrote:
> On 2014/07/10 21:54:37, danakj wrote:
> >
>
https://codereview.chromium.org/376193002/diff/130001/components/user_manager...
> > File components/user_manager/DEPS (right):
> > 
> >
>
https://codereview.chromium.org/376193002/diff/130001/components/user_manager...
> > components/user_manager/DEPS:3: "+ui/gfx",
> > you need all of ui/gfx?
> 
> Probably just ui/gfx/codec.
> I'll updated that in follow up.

Updated in https://codereview.chromium.org/379803004/

Powered by Google App Engine
This is Rietveld 408576698